From: Kunal Mehta <legoktm@gmail.com>
Date: Tue, 19 May 2015 05:30:37 +0000 (-0700)
Subject: registration: Don't array_unique() over the queue before loading it
X-Git-Tag: 1.31.0-rc.0~11365
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/categories/modifier.php?a=commitdiff_plain;h=1be36f6356bc6fd76586518001bc76c3d9b9aa14;p=lhc%2Fweb%2Fwiklou.git

registration: Don't array_unique() over the queue before loading it

array_unique works over values, not keys (you can't have an array with
duplicate keys in PHP) so it would end up removing extensions that
happened to have an identical timestamp with another one.

Bug: T98956
Change-Id: I66e202ea882ae4d5cb1bcafb7882cbd9cd52a1b3
---

diff --git a/includes/registration/ExtensionRegistry.php b/includes/registration/ExtensionRegistry.php
index d938f07272..48362757b2 100644
--- a/includes/registration/ExtensionRegistry.php
+++ b/includes/registration/ExtensionRegistry.php
@@ -90,8 +90,6 @@ class ExtensionRegistry {
 			return;
 		}
 
-		$this->queued = array_unique( $this->queued );
-
 		// See if this queue is in APC
 		$key = wfMemcKey( 'registration', md5( json_encode( $this->queued ) ) );
 		$data = $this->cache->get( $key );