From: Derick Alangi <alangiderick@gmail.com>
Date: Wed, 15 May 2019 14:17:23 +0000 (+0100)
Subject: SearchResultSet: MW version number should be a string in wfDeprecated call
X-Git-Tag: 1.34.0-rc.0~1673^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/%22%24ccApp/ecrire?a=commitdiff_plain;h=09567cc3680e97ad004599d7b8f35d84b1e38edf;p=lhc%2Fweb%2Fwiklou.git

SearchResultSet: MW version number should be a string in wfDeprecated call

Seems this was a typo and I think 1.32 which is a double/float will be
implicitly converted to true (bool) because it will resolve 1.32 to 1 as
integer and then 1 which maps to true (bool).

To avoid this, use '1.32' instead of the integer form of the version.

Change-Id: Ifaf6ab0d36bc02bd1707f8caf375f65a30eb1af5
---

diff --git a/includes/search/SearchResultSet.php b/includes/search/SearchResultSet.php
index 18331ddc75..3d3b4460bd 100644
--- a/includes/search/SearchResultSet.php
+++ b/includes/search/SearchResultSet.php
@@ -84,7 +84,7 @@ class SearchResultSet implements Countable, IteratorAggregate {
 			// This class will eventually be abstract. SearchEngine implementations
 			// already have to extend this class anyways to provide the actual
 			// search results.
-			wfDeprecated( __METHOD__, 1.32 );
+			wfDeprecated( __METHOD__, '1.32' );
 		}
 		$this->containedSyntax = $containedSyntax;
 		$this->hasMoreResults = $hasMoreResults;