From 62e25771a18828cd0e0df11bb331ad7a3876a59f Mon Sep 17 00:00:00 2001
From: Jeroen De Dauw <jeroendedauw@users.mediawiki.org>
Date: Tue, 20 Jul 2010 11:27:52 +0000
Subject: [PATCH] Clarified field and method visibility and added TODOs

---
 includes/installer/OracleInstaller.php | 31 +++++++++++++++++---------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/includes/installer/OracleInstaller.php b/includes/installer/OracleInstaller.php
index be203c5cae..3d56448f32 100644
--- a/includes/installer/OracleInstaller.php
+++ b/includes/installer/OracleInstaller.php
@@ -15,7 +15,7 @@ class OracleInstaller extends DatabaseInstaller {
 		'_InstallPassword' => '',
 	);
 
-	function getName() {
+	public function getName() {
 		return 'oracle';
 	}
 
@@ -23,7 +23,7 @@ class OracleInstaller extends DatabaseInstaller {
 		return self::checkExtension( 'oci8' );
 	}
 
-	function getConnectForm() {
+	public function getConnectForm() {
 		return
 			Xml::openElement( 'fieldset' ) .
 			Xml::element( 'legend', array(), wfMsg( 'config-db-wiki-settings' ) ) .
@@ -35,7 +35,7 @@ class OracleInstaller extends DatabaseInstaller {
 			$this->getInstallUserBox();
 	}
 
-	function submitConnectForm() {
+	public function submitConnectForm() {
 		// Get variables from the request
 		$newValues = $this->setVarsFromRequest( array( 'wgDBname', 'wgDBprefix' ) );
 
@@ -77,20 +77,31 @@ class OracleInstaller extends DatabaseInstaller {
 	}
 
 
-	function getSettingsForm() {}
+	public function getSettingsForm() {
+		// TODO
+	}
 	
-	function submitSettingsForm() {}
+	public function submitSettingsForm() {
+		// TODO
+	}
 
-	function getConnection() {}
+	public function getConnection() {
+		// TODO
+	}
 
-	function setupDatabase() {}
+	public function setupDatabase() {
+		// TODO
+	}
 
-	function createTables() {}
+	public function createTables() {
+		// TODO
+	}
 
-	function getLocalSettings() {
+	public function getLocalSettings() {
 		$prefix = $this->getVar( 'wgDBprefix' );
 		return
 "# Oracle specific settings
 \$wgDBprefix         = \"{$prefix}\";";
 	}
-}
+	
+}
\ No newline at end of file
-- 
2.20.1