Umherirrender [Wed, 19 Jun 2019 19:42:32 +0000 (21:42 +0200)]
Type hint against IResultWrapper in maintenance classes
Change-Id: I6a58e9cfe645056a854c80b2db1e71fb59bd226b
jenkins-bot [Wed, 19 Jun 2019 14:10:33 +0000 (14:10 +0000)]
Merge "resourceloader: Define the default language and skin in constants"
Fomafix [Sun, 16 Jun 2019 20:30:15 +0000 (22:30 +0200)]
resourceloader: Define the default language and skin in constants
This allows to use the default values at several places.
Change-Id: I53f29c2162c4cac9caf672e816ebfeb97c452389
jenkins-bot [Wed, 19 Jun 2019 13:27:07 +0000 (13:27 +0000)]
Merge "rdbms: mention wait time in LoadBalancer::safeWaitForMasterPos() error logging"
jenkins-bot [Wed, 19 Jun 2019 13:27:01 +0000 (13:27 +0000)]
Merge "rdbms: merge openConnection into getConnection in LoadBalancer"
jenkins-bot [Wed, 19 Jun 2019 12:40:12 +0000 (12:40 +0000)]
Merge "resourceloader: Migrate use of 'raw' modules to 'raw' requests"
jenkins-bot [Wed, 19 Jun 2019 12:26:04 +0000 (12:26 +0000)]
Merge "resourceloader: Remove redundant 'group' setting for StartupModule"
jenkins-bot [Wed, 19 Jun 2019 11:20:31 +0000 (11:20 +0000)]
Merge "resourceloader: Ignore coverage for getBaseModulesInternal() wrapper"
Aaron Schulz [Mon, 17 Jun 2019 18:16:12 +0000 (19:16 +0100)]
rdbms: merge openConnection into getConnection in LoadBalancer
Add error suppression feature to getConnection() itself so that
callers can easily be migrated to it. Deprecate openConnection(),
which is poorly named and had a poor division of responsibility
with getConnection().
Split out some new private methods for readability:
* sanitizeConnectionFlags(), which warns about and strips unusable flags
* enforceConnectionFlags(), which handles some DBO_TRX sanity logic
* lazyLoadReplicationPositions(), which handles the chronology callback
Make sure "waitForPos" is loaded before pickReaderIndex() so that the
optimization of being extra picky about replication lag (in seconds)
actually applies.
Change-Id: I225ed6e6edf39cdf237f2322ea59f35d30f2e01a
jenkins-bot [Wed, 19 Jun 2019 06:56:00 +0000 (06:56 +0000)]
Merge "phan: Add internal stubs for imagick, pcntl, redis & sockets"
Aaron Schulz [Wed, 19 Jun 2019 02:19:53 +0000 (03:19 +0100)]
rdbms: mention wait time in LoadBalancer::safeWaitForMasterPos() error logging
Change-Id: I134e58949bab25e73874ea29d1b306e4fffa6ef9
jenkins-bot [Wed, 19 Jun 2019 02:14:15 +0000 (02:14 +0000)]
Merge "language: Move some language-related classes to includes/language/"
jenkins-bot [Wed, 19 Jun 2019 02:11:22 +0000 (02:11 +0000)]
Merge "Various cleanups to MediaWiki::preOutputCommit"
jenkins-bot [Wed, 19 Jun 2019 01:35:47 +0000 (01:35 +0000)]
Merge "Use UUIDv4 for mediawiki.api-request log event ID."
jenkins-bot [Wed, 19 Jun 2019 01:25:09 +0000 (01:25 +0000)]
Merge "Fix return type of UploadStash::listFiles"
Petr Pchelko [Wed, 15 May 2019 05:06:09 +0000 (07:06 +0200)]
Use UUIDv4 for mediawiki.api-request log event ID.
Bug: T222966
Change-Id: Ie753229ed15545a62349154d442ae9e297951455
jenkins-bot [Tue, 18 Jun 2019 23:40:01 +0000 (23:40 +0000)]
Merge "Use IDatabase as return type for BotPassword::getDB"
jenkins-bot [Tue, 18 Jun 2019 22:59:07 +0000 (22:59 +0000)]
Merge "resourceloader: Skip modules with circular deps in tree optimiser"
Timo Tijhof [Thu, 13 Jun 2019 21:02:36 +0000 (22:02 +0100)]
language: Move some language-related classes to includes/language/
Bug: T225756
Change-Id: Ica351483d83a3a912d58ebb194b30828541fbcf3
jenkins-bot [Tue, 18 Jun 2019 20:34:15 +0000 (20:34 +0000)]
Merge "rdbms: Fix return type of DatabaseMysqlBase::mysqlFetchArray"
jenkins-bot [Tue, 18 Jun 2019 20:33:42 +0000 (20:33 +0000)]
Merge "resourceloader: Fix return type in ResourceLoader-related classes"
Timo Tijhof [Thu, 13 Jun 2019 18:28:38 +0000 (19:28 +0100)]
resourceloader: Ignore coverage for getBaseModulesInternal() wrapper
The getBaseModules() method is covered already.
Change-Id: I92d9063b72cee9e3be7329927bf5b97028399c14
Umherirrender [Tue, 18 Jun 2019 20:18:49 +0000 (22:18 +0200)]
rdbms: Fix return type of DatabaseMysqlBase::mysqlFetchArray
Change-Id: I7797ae79e8b4c1a88a4f1da342ef4a4f5a78ed74
Umherirrender [Tue, 18 Jun 2019 20:17:41 +0000 (22:17 +0200)]
resourceloader: Fix return type in ResourceLoader-related classes
Change-Id: I543e321129cf8fadc1159017b622528f462ea116
Umherirrender [Tue, 18 Jun 2019 19:40:09 +0000 (21:40 +0200)]
Use IDatabase as return type for BotPassword::getDB
There is no guarantee that this is a maintenance able connection,
but drop, create or alter is also not needed in this case
Change-Id: I7dd294b3d28ef8c4e416e826f38ed39f824b2f8f
jenkins-bot [Tue, 18 Jun 2019 19:38:45 +0000 (19:38 +0000)]
Merge "Return null from overwritten FormlessAction::onView"
jenkins-bot [Tue, 18 Jun 2019 19:38:39 +0000 (19:38 +0000)]
Merge "Update type of PermissionManager::resultToError"
jenkins-bot [Tue, 18 Jun 2019 19:38:33 +0000 (19:38 +0000)]
Merge "Fix return type of GenerateSitemap::getPageRes"
jenkins-bot [Tue, 18 Jun 2019 19:35:14 +0000 (19:35 +0000)]
Merge "Fix return type of CeeFormatter::format"
Kunal Mehta [Tue, 18 Jun 2019 19:19:37 +0000 (15:19 -0400)]
phan: Add internal stubs for imagick, pcntl, redis & sockets
Phan will automatically use these stubs if the extensions are not installed.
Also added a brief README for how to generate the stubs in the first place.
Bug: T224893
Change-Id: I1d31d03801fbc7b18dfc758453c95439acd96d19
Umherirrender [Tue, 18 Jun 2019 19:13:10 +0000 (21:13 +0200)]
Fix return type of CeeFormatter::format
FormatterInterface defines the return type as mixed
Change-Id: I41735b9fe887f9436cf6294a46eb5419c8da251f
Umherirrender [Tue, 18 Jun 2019 19:10:39 +0000 (21:10 +0200)]
Return null from overwritten FormlessAction::onView
The abstract class is documented to use null for doing nothing, not void
Change-Id: I99f0747117f83f4f2ae554c759a8e1737e7dc8f7
Umherirrender [Tue, 18 Jun 2019 18:33:53 +0000 (20:33 +0200)]
Fix return type of UploadStash::listFiles
SpecialUploadStash is using the return and already checking for truthy
Change-Id: Ie26f327d5ec9d67c39cf757591d2a779aecda86f
jenkins-bot [Tue, 18 Jun 2019 18:32:40 +0000 (18:32 +0000)]
Merge "ApiCSPReport: Support origin/path matching for false positives"
Umherirrender [Tue, 18 Jun 2019 18:28:37 +0000 (20:28 +0200)]
Fix return type of GenerateSitemap::getPageRes
Change-Id: I68729366f294b93aab5d2c76581c0847c11076d7
jenkins-bot [Tue, 18 Jun 2019 18:19:52 +0000 (18:19 +0000)]
Merge "ApiCSPReport: Log user ID instead of name, and limit urls to origin"
jenkins-bot [Tue, 18 Jun 2019 16:00:41 +0000 (16:00 +0000)]
Merge "WebInstaller: Add ARIA `role="main"` to overall div"
jenkins-bot [Tue, 18 Jun 2019 15:48:54 +0000 (15:48 +0000)]
Merge "Introduce separate unit tests PHPUnit configuration"
Volker E [Tue, 18 Jun 2019 00:23:13 +0000 (17:23 -0700)]
WebInstaller: Add ARIA `role="main"` to overall div
Adding ARIA `main` role on appropriate element to keep in sync with
WMF deployed themes.
Change-Id: I9436fd4478e2b108a7ec588db0a628d7d5c26fcd
Máté Szabó [Mon, 17 Jun 2019 21:15:25 +0000 (23:15 +0200)]
Introduce separate unit tests PHPUnit configuration
This changeset lays down the basic groundwork required to implement
T89432 and related tickets and is based on exploration done
at the Prague Hackathon. The goal is to identify tests in MediaWiki core
that can be run without having to install & configure MediaWiki and its dependencies,
and provide a way to execute these tests via the standard phpunit entry point,
allowing for faster development and integration with existing tooling like IDEs.
This changeset creates a new subdirectory under phpunit/ and organizes it
into a separate test suite. The environment for this suite is set up
via a PHPUnit bootstrap file without a custom entry point. For B/C, this
directory is also registered in suite.xml, to ensure that existing CI jobs
still pick up tests in the new suite.
For initial testing, a single test class, PasswordFactoryTest, was moved
to this new suite.
You can run the new suite using the follwoing command:
$ vendor/bin/phpunit -d memory_limit=512M -c tests/phpunit/unit-tests.xml
Bug: T84948
Bug: T89432
Bug: T87781
Change-Id: I69b92db3e70093570e05cc0a64c7780a278b321a
Umherirrender [Fri, 8 Jun 2018 20:16:21 +0000 (22:16 +0200)]
rdbms: Document varargs for IDatabase::buildLike
This is needed in order for Phan not to consider calls to
IDatabase::buildLike as invalid. Interestingly, it does not
consider calls to Database::buildLike invalid.
Bug: T191668
Change-Id: I0e027f5ec66d20b1d11e3441086001f6a751e1f5
Aaron Schulz [Tue, 18 Jun 2019 10:46:40 +0000 (11:46 +0100)]
Various cleanups to MediaWiki::preOutputCommit
Do not send headers if they were already flushed. Split off some
chronology protection logic into a separate private method. Use
ILBFactory over LBFactory in a few places. Also, update various
code comments.
Bug: T225655
Change-Id: Iecb574e11d8ba09147ff7b84ad57d8845069ba99
jenkins-bot [Tue, 18 Jun 2019 06:10:51 +0000 (06:10 +0000)]
Merge "Add link trail for Azerbaijani language"
jenkins-bot [Tue, 18 Jun 2019 01:30:50 +0000 (01:30 +0000)]
Merge "shell: Remove documentation that doesn't add meaning to the method"
Timo Tijhof [Tue, 18 Jun 2019 00:00:41 +0000 (01:00 +0100)]
DevelopmentSettings: Document why wgRateLimits is disabled
Follows-up
9c52f982d8.
Bug: T225796
Change-Id: I6f7a75d58c61712233134a9d480ce68719d6cb6a
jenkins-bot [Mon, 17 Jun 2019 23:50:43 +0000 (23:50 +0000)]
Merge "Remove unused/deprecated Replacer classes"
jenkins-bot [Mon, 17 Jun 2019 23:36:33 +0000 (23:36 +0000)]
Merge "Installer: Use HTML/CSS instead of JavaScript to toggle the help message"
jenkins-bot [Mon, 17 Jun 2019 22:55:20 +0000 (22:55 +0000)]
Merge "Add a report about slow PHPUnit tests"
Max Semenik [Sun, 16 Jun 2019 06:11:50 +0000 (23:11 -0700)]
Add a report about slow PHPUnit tests
johnkary/phpunit-speedtrap prints this information right before the
test results.
Bug: T225730
Change-Id: I288dcd6b3c9b2c0b31c6047eaf48a23e13af726e
Translation updater bot [Mon, 17 Jun 2019 20:06:02 +0000 (22:06 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I78a1cea264df6fa322b5df4a342882fb867a2c1a
jenkins-bot [Mon, 17 Jun 2019 20:00:45 +0000 (20:00 +0000)]
Merge "Use [...] instead of array(...) in PHP comments and documentation"
Kunal Mehta [Mon, 17 Jun 2019 19:23:06 +0000 (15:23 -0400)]
Remove unused/deprecated Replacer classes
Change-Id: Ifec6c624810b2354f2fab2c1fd4a27267b625c4b
jenkins-bot [Mon, 17 Jun 2019 19:39:03 +0000 (19:39 +0000)]
Merge "Installer: Make short header and normal header of WebInstaller equivalent"
Fomafix [Fri, 14 Jun 2019 09:07:33 +0000 (11:07 +0200)]
Installer: Make short header and normal header of WebInstaller equivalent
Change-Id: I8ae0cca582c2dab87a4b3b050030f6c96897939e
Fomafix [Mon, 16 Jan 2017 15:42:53 +0000 (16:42 +0100)]
Use [...] instead of array(...) in PHP comments and documentation
Change-Id: I0c83783051bf35fe785bc01644eeb2946902b6b2
jenkins-bot [Mon, 17 Jun 2019 18:35:34 +0000 (18:35 +0000)]
Merge "Fix some issues with HTMLSelectAndOtherField default and validation"
jenkins-bot [Mon, 17 Jun 2019 18:02:31 +0000 (18:02 +0000)]
Merge "resourceloader: Remove unused static $contexts var in ResourceLoaderImageTest"
jenkins-bot [Mon, 17 Jun 2019 17:59:44 +0000 (17:59 +0000)]
Merge "FileRepo: Use Late Static Binding in File static constructors"
Fomafix [Sun, 16 Jun 2019 11:59:59 +0000 (13:59 +0200)]
resourceloader: Remove unused static $contexts var in ResourceLoaderImageTest
Change-Id: I95abbfd6d2baafb9378072fdf1a1fc5ed046cec3
jenkins-bot [Mon, 17 Jun 2019 17:20:47 +0000 (17:20 +0000)]
Merge "Filter out blocks with duplicate IDs when checking for blocks"
jenkins-bot [Mon, 17 Jun 2019 16:48:05 +0000 (16:48 +0000)]
Merge "rdbms: clean up and simplify toString() handle for Database"
Derick Alangi [Mon, 17 Jun 2019 16:40:37 +0000 (17:40 +0100)]
shell: Remove documentation that doesn't add meaning to the method
Change-Id: I924453f683f058586516bb12e54940449d29cfd9
Thalia [Mon, 17 Jun 2019 09:56:49 +0000 (10:56 +0100)]
Filter out blocks with duplicate IDs when checking for blocks
Bug: T225919
Change-Id: I76549072d53083e6057f4fd8fe963e8989daa25c
jenkins-bot [Mon, 17 Jun 2019 11:11:45 +0000 (11:11 +0000)]
Merge "[bugfix] Fetch tag ID before calling undefineTag()"
Leszek Manicki [Mon, 17 Jun 2019 09:11:39 +0000 (11:11 +0200)]
Disable rate limiting in Development Settings
Bug: T225796
Change-Id: I2475a04066d4aaefeba372bd223ef68548a8cf18
jenkins-bot [Mon, 17 Jun 2019 07:54:27 +0000 (07:54 +0000)]
Merge "Fix param type of search terms in search related classes"
jenkins-bot [Mon, 17 Jun 2019 01:53:48 +0000 (01:53 +0000)]
Merge "rdbms: allow synchronous=OFF for sqlite"
jenkins-bot [Mon, 17 Jun 2019 01:03:47 +0000 (01:03 +0000)]
Merge "search: clean up some type hints in search classes"
jenkins-bot [Mon, 17 Jun 2019 00:50:47 +0000 (00:50 +0000)]
Merge "rdbms: do not close the connection in LoadBalancerSingle::__destruct"
Aaron Schulz [Mon, 17 Jun 2019 00:47:32 +0000 (01:47 +0100)]
rdbms: allow synchronous=OFF for sqlite
Change-Id: I58be09bb170399f3ad94fc3bcc4881932d357a9b
Aaron Schulz [Sun, 16 Jun 2019 22:13:02 +0000 (23:13 +0100)]
search: clean up some type hints in search classes
Change-Id: I357a78b42ea02a63c3b64e8982f04314cbbfdf9f
Aaron Schulz [Sun, 16 Jun 2019 23:20:55 +0000 (00:20 +0100)]
rdbms: do not close the connection in LoadBalancerSingle::__destruct
The connection instance is injected unlike with the parent class,
meaning that it does not own the connection. No-op the method.
Change-Id: I61914b986619f201ac9cc8c94d46873a3b9e8177
Kosta Harlan [Sun, 16 Jun 2019 23:00:52 +0000 (19:00 -0400)]
Only attempt to deduplicate if there is data in archive and revision
The idea is to avoid expensive calls to makeDummyRevisionRow, and speed up
installation of MediaWiki on CI.
Bug: T225901
Change-Id: I6f69281568218c89eb18353c06cabf7eb1926de8
Translation updater bot [Sun, 16 Jun 2019 20:01:56 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I84ab99cdcd91ee6dab8ae284e8b1c6aea53cefac
Martin Urbanec [Sun, 16 Jun 2019 14:15:22 +0000 (16:15 +0200)]
[bugfix] Fetch tag ID before calling undefineTag()
undefineTag() also deletes the tag if it's not used anywhere,
which is breaking the rest of deleteTagEverywhere() in that case.
Bug: T225564
Change-Id: I7ca5db9efd0088b266e33c0a9ce78d73a4fa87c9
MarcoAurelio [Tue, 11 Jun 2019 11:38:50 +0000 (11:38 +0000)]
Use secure protocols on Wikimedia sites
Change-Id: I3af0038202027a737a306ae677f7cda2b9857404
jenkins-bot [Sun, 16 Jun 2019 07:17:18 +0000 (07:17 +0000)]
Merge "Reduce HashRing test load to avoid several seconds of CPU"
Máté Szabó [Wed, 22 May 2019 19:26:35 +0000 (21:26 +0200)]
FileRepo: Use Late Static Binding in File static constructors
The FileRepo extension API allows to specify factory methods that
FileRepo implementations will use to instantiate File instances.
Currently, the default static constructors in LocalFile and OldLocalFile
do not use Late Static Binding, so every subclass is forced to re-implement them,
even if they would not need any custom logic. Switching to Late Static Binding
(available since PHP 5.3) allows File implementors to reduce boilerplate
if they do not need to overwrite the existing logic.
Change-Id: Id8f6f5362b68269c2a3232796a1703be14116dd5
Aaron Schulz [Sat, 15 Jun 2019 10:42:14 +0000 (11:42 +0100)]
rdbms: clean up and simplify toString() handle for Database
Change-Id: Ia95e25505785aad71b70a74f4ec7a07a73e419e1
Fomafix [Thu, 8 Nov 2018 19:18:27 +0000 (20:18 +0100)]
Installer: Use HTML/CSS instead of JavaScript to toggle the help message
Changes in the behavior:
* The expanding/collapsing now works even with disabled JavaScript.
* There is no FOUC on loading anymore.
* The animation on show/hide is absent.
Change-Id: I1b88d8e2cdbb1c969670a7a8637dba10bf447330
jenkins-bot [Sat, 15 Jun 2019 09:47:50 +0000 (09:47 +0000)]
Merge "resourceloader: Support 'versionCallback' for computed package files"
Thalia [Thu, 13 Jun 2019 19:04:49 +0000 (20:04 +0100)]
Fix some issues with HTMLSelectAndOtherField default and validation
Bring HTMLSelectAndOtherField in line with other HTMLFormFields by
ensuring that the default value is of the correct type and passes
validation checks.
Also make sure HTMLSelectAndOtherField::validate checks for the
final value, if the field has required set to true.
Bug: T222170
Bug: T225860
Change-Id: I949ee3df2b1f597982cf522b149c54b8e79d59bc
jenkins-bot [Fri, 14 Jun 2019 22:39:07 +0000 (22:39 +0000)]
Merge "PHPVersionCheck: remove version_compare() existence check"
Max Semenik [Fri, 14 Jun 2019 01:36:14 +0000 (18:36 -0700)]
PHPVersionCheck: remove version_compare() existence check
It was added to PHP in 2001.
Change-Id: I3b14d726aa1cefd6b64e4bac39ef489b3c79ac1a
jenkins-bot [Fri, 14 Jun 2019 21:28:45 +0000 (21:28 +0000)]
Merge "mw.Uri: Use more intuitive variable names"
jenkins-bot [Fri, 14 Jun 2019 20:33:41 +0000 (20:33 +0000)]
Merge "Hard deprecate Preprocessor_DOM"
jenkins-bot [Fri, 14 Jun 2019 18:26:48 +0000 (18:26 +0000)]
Merge "Use HTTPS for creativecommons.org"
jenkins-bot [Fri, 14 Jun 2019 18:26:07 +0000 (18:26 +0000)]
Merge "resourceloader: Validate ResourceLoaderContext::getDirection() input"
jenkins-bot [Fri, 14 Jun 2019 18:25:09 +0000 (18:25 +0000)]
Merge "Installer: Move style of background image from HTML to CSS"
jenkins-bot [Fri, 14 Jun 2019 18:17:23 +0000 (18:17 +0000)]
Merge "user: Move idFromName cache truncation to before adding the new value"
Fomafix [Tue, 11 Jun 2019 19:54:57 +0000 (21:54 +0200)]
resourceloader: Validate ResourceLoaderContext::getDirection() input
Only dir=ltr and dir=rtl are now allowed. Ignore other values.
Change-Id: Id39471e8a792c7c48ff7ca9d80be2e6dd4caee6b
jenkins-bot [Fri, 14 Jun 2019 18:12:51 +0000 (18:12 +0000)]
Merge "Add a custom block message for composite blocks"
Alexia E. Smith [Fri, 14 Jun 2019 17:40:54 +0000 (12:40 -0500)]
user: Move idFromName cache truncation to before adding the new value
This prevents a double query for the same User::idFromName() call
twice in a row.
Bug: T225843
Change-Id: I5beb0a3ad5e715b68dd8a450408fb089184fa6ce
Bartosz Dziewoński [Fri, 14 Jun 2019 18:02:58 +0000 (20:02 +0200)]
mw.Uri: Use more intuitive variable names
Change-Id: I8e53d7a0e0b89909a5c3798a819a0690c757a060
Umherirrender [Fri, 7 Jun 2019 18:43:02 +0000 (20:43 +0200)]
Fix param type of search terms in search related classes
Change-Id: I036434268f1e7992f7f9f23d2c1c0fcd399823c8
Saint Johann [Fri, 14 Jun 2019 17:14:01 +0000 (17:14 +0000)]
Add link trail for Azerbaijani language
Bug: T224614
Change-Id: If17cd3906d17cf5ffee6f6e99f46eb09b28a7153
Timo Tijhof [Wed, 12 Jun 2019 00:57:17 +0000 (01:57 +0100)]
resourceloader: Support 'versionCallback' for computed package files
The use cases we've seen for using computed (or virtual) package files,
involve expensive computations to expand and transform data for the client
that we don't want to evaluate in full just to compute the module's version
hash (e.g. in the StartupModule, where we need to do this for 1000s of
modules).
For such cases, the module can specify a 'versionCallback' of which the
return value will be used to seed the module's version hash. The default
remains the same as before, which is to use the full content to seed the
version hash (via getDefinitionSummary).
Bug: T223260
Change-Id: I76f573239e6bd429287e7adb33a92ffd5e260c20
Timo Tijhof [Thu, 13 Jun 2019 19:13:35 +0000 (20:13 +0100)]
resourceloader: Migrate use of 'raw' modules to 'raw' requests
The ResourceLoaderModule::isRaw() feature and the ability to magically
switch a regular load.php request into raw mode is being removed soon.
Instead, specify raw=1 in the request url where that behaviour is needed.
Bug: T201483
Change-Id: Ie4564ec8e26ad53f2de1a43330d18a35b0498a63
C. Scott Ananian [Tue, 9 Apr 2019 18:42:42 +0000 (14:42 -0400)]
Hard deprecate Preprocessor_DOM
The Preprocessor_DOM implementation doesn't interact well with PHP memory
profiling, and has some limitations not present in the Preprocessor_Hash
implementation (see T216664). There is no reason to keep around two
versions of the preprocessor: it just complicates on-going wikitext
feature development.
Hard deprecate use of Preprocessor_DOM, so we can remove the redundant
code in a future release.
Bug: T204945
Depends-On: Id38c9360e4d02b570996dbf7a660f964f02f1a2c
Change-Id: Ica5d1ad5b1e677542962fc36d582a793f941155e
Timo Tijhof [Thu, 13 Jun 2019 18:33:46 +0000 (19:33 +0100)]
resourceloader: Remove redundant 'group' setting for StartupModule
This feaure exists for controlling cache fragmentation of modules
that are queued for loading. However, the startup module is never
"queued" for loading.
It's loading is hardwired into ResourceLoaderClientHtml and doesn't
use any batching and couldn't logically, given that by design it
has to be the first thing that loads and cannot be combined with
other code (because we need to be able to return early and control
what else gets loaded from there).
[0] https://www.mediawiki.org/wiki/ResourceLoader/Architecture#Balance
Change-Id: If8900c538ce623f6a9a68a3bbef0927b4b6ae346