jenkins-bot [Tue, 7 Oct 2014 06:46:11 +0000 (06:46 +0000)]
Merge "UploadBaseTest: Use setMwGlobals() instead of juggling globals"
jenkins-bot [Tue, 7 Oct 2014 06:45:08 +0000 (06:45 +0000)]
Merge "MWCryptHKDFTest: Mock $wgSecretKey to ensure atomicity"
Tim Starling [Tue, 7 Oct 2014 05:24:45 +0000 (16:24 +1100)]
HashBagOStuff: use the value itself as the CAS token
Avoid an unnecessary serialize() call on get() requests, which makes it
faster and also happens to work around a nasty crash bug which is
causing lots of segfaults right now.
CAS semantics should be the same, if the caller handles a CAS token in
an opaque way and does not assume it is a string. I could only find one
caller of cas() in core and WMF deployed extensions, and that is
BagOStuff::mergeViaCas(), which does correctly handle CAS tokens of any
type.
Bug: 71724
Change-Id: I0b0b5f0157c005ec7f76210dfb8576c056314733
Timo Tijhof [Tue, 7 Oct 2014 03:22:02 +0000 (05:22 +0200)]
MWCryptHKDFTest: Mock $wgSecretKey to ensure atomicity
Follows-up
af66c04.
The tests depend indirectly on wgSecretKey (used by
MWCryptHKDF::generateHex). On test installs I tend to set this
to "example" or "***", which is less than 16 characters and thus
the unit tests failed with "MWCryptHKDF secret was too short".
Change-Id: I9a85fd9fbb345863e4837fed2910d60ebf1b0d83
Timo Tijhof [Tue, 7 Oct 2014 03:13:32 +0000 (05:13 +0200)]
UploadBaseTest: Use setMwGlobals() instead of juggling globals
Abstracts the logic for restoration into the built-in teardown()
handler.
Also purify the test configuration by setting wgHooks and
wgFileExtensions to otherwise empty arrays instead of extending
existing ones.
Change-Id: Ied65ee62f658dd650c603a54e72cd19965867a8f
jenkins-bot [Tue, 7 Oct 2014 00:31:38 +0000 (00:31 +0000)]
Merge "SpecialWhatlinkshere: Add autocompletion for target input"
aude [Mon, 6 Oct 2014 14:07:37 +0000 (16:07 +0200)]
Log non-MediaWiki exceptions for requests via main entry point
Previously, non-MediaWiki exceptions were logged only for api requests,
job runner, resource loader, etc. but not for general requests
such as page views.
Bug: 61914
Change-Id: Id4de5cac0b9996a98cdaf5e73655d49fa55ea8c3
PiRSquared17 [Wed, 14 May 2014 20:32:53 +0000 (20:32 +0000)]
SpecialWhatlinkshere: Add autocompletion for target input
This adds the mw-searchInput class so suggestions are given by
mediawiki.searchSuggest (if loaded by the skin).
Bug: 65209
Change-Id: If4ae687ba125c002eedce114820a271cf615011b
Translation updater bot [Mon, 6 Oct 2014 18:59:05 +0000 (20:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia0998d81e51a5081b31ca8146f7ec7ef67f75d09
Kevin Israel [Mon, 6 Oct 2014 14:18:32 +0000 (10:18 -0400)]
Remove SquidUpdate::newFromLinksTo()
This has been broken since r9199 /
e0ce5a322e41; a DB query error will occur
because the links table no longer exists, and even if the table were to
exist, the pl_* columns would not exist in that table.
There is no usage in core or Gerrit-hosted extensions.
Change-Id: I4922f85417bfb4d40f08662ba100ab5b78edd5fb
jenkins-bot [Mon, 6 Oct 2014 18:00:53 +0000 (18:00 +0000)]
Merge "Tune Skin::preloadExistence"
James D. Forrester [Mon, 6 Oct 2014 16:03:54 +0000 (09:03 -0700)]
Update OOjs UI to v0.1.0-pre (
26dadbc60f)
New changes:
6c91643 Make buttons respond to :active events
9137aaf Move window overlay up to be a sibling of the frame
19d8c83 ComboBoxWidget: Append menu to $overlay option
eb0fcb8 InlineMenuWidget: Fix documentation
19d2c2b SelectWidget: Fix typos in documentation
495d281 TextInputMenuWidget: Fix typo in documentation
b4ae961 Toolbar: Correctly display "More" label on catch-all groups
32e769e Toolbar demo: Fix tool name mismatch
e9983b6 build: Clean up Grunt config and add missing csscomb run
Change-Id: I1ee2e51460c709fa01934ae7d58ac8411b124867
aude [Mon, 6 Oct 2014 09:03:54 +0000 (11:03 +0200)]
Move TimestampException to exception directory
Change-Id: Id3829cbd155636839a272dc7e28e45bee7b87e8b
jenkins-bot [Mon, 6 Oct 2014 07:16:11 +0000 (07:16 +0000)]
Merge "Adjust h3 size to keep it smaller than h2 across normal platforms"
Jackmcbarn [Mon, 6 Oct 2014 01:06:46 +0000 (21:06 -0400)]
Include categories in Special:ExpandTemplates
Show the categories box at the bottom of the page,
which more accurately represents what the page would
look like and allows users to see the effective
categories of the expanded page.
Bug: 71633
Change-Id: I4c003fb1f42b29602cd8924b224ff7642e8cf857
jenkins-bot [Sun, 5 Oct 2014 20:09:58 +0000 (20:09 +0000)]
Merge "Update usage of getRedirectSnippet() and getSectionSnippet()"
Mark A. Hershberger [Sun, 5 Oct 2014 20:02:05 +0000 (16:02 -0400)]
Update usage of getRedirectSnippet() and getSectionSnippet()
Meant to include this in I571e015814ea756771c66c243cb8db86448db463 but
it was missed.
Change-Id: I9ff805daee1c10d7ea75dedd0ba59b467aaadd50
Translation updater bot [Sun, 5 Oct 2014 19:44:46 +0000 (21:44 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ide1bf69a2454e7031c3b373184e2f32a57d66b59
jenkins-bot [Sun, 5 Oct 2014 18:30:31 +0000 (18:30 +0000)]
Merge "Update usage of getTitleSnippet(), getRedirectSnippet() and getSectionSnippet()"
umherirrender [Sun, 5 Oct 2014 17:26:36 +0000 (19:26 +0200)]
Tune Skin::preloadExistence
Just preload user page and talk, when the personal bar is shown.
Use Skin::getRelevantTitle for the title to have the correct title
preloaded, when using for example [[Special:WhatLinksHere]].
Change-Id: I4363a9f3fd909cfdc341dc1a8c6c0189efd9b736
umherirrender [Sun, 5 Oct 2014 17:08:15 +0000 (19:08 +0200)]
Undefined variable: attrs in HistoryAction.php on line 202
Replaced by an array() and removed an unused variable near by.
Follow-Up: I61bb3c358f755ed9f2153d94b744c1a9da02c456
Change-Id: I5c4dc22e1e9346bfc410a9dda4353d5297a5825e
jenkins-bot [Sun, 5 Oct 2014 08:00:14 +0000 (08:00 +0000)]
Merge "jquery.ui: Collapse border in ui-helper-clearfix"
jenkins-bot [Sat, 4 Oct 2014 21:34:25 +0000 (21:34 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (
48980881f3)"
jenkins-bot [Sat, 4 Oct 2014 20:35:30 +0000 (20:35 +0000)]
Merge "Fix for Bug 63980 - Comparison of limits in pingLimiter is incorrect"
jenkins-bot [Sat, 4 Oct 2014 20:19:36 +0000 (20:19 +0000)]
Merge "Add comment to AFL_* constants in Defines.php"
Amir E. Aharoni [Sat, 4 Oct 2014 14:02:55 +0000 (17:02 +0300)]
Avoid extra-long code lines
Makes phpcs happy.
Change-Id: Ideb4d4e7b9f5c385f108b91b26a796ecf6833d47
Amir E. Aharoni [Sat, 4 Oct 2014 13:29:43 +0000 (16:29 +0300)]
Whitespace correction
Change-Id: Ia6e9c1e47bf6289398a38e6b4b2f5055e30ba4fb
jenkins-bot [Sat, 4 Oct 2014 12:46:36 +0000 (12:46 +0000)]
Merge "mediawiki.page.image.pagination: Cache last-loaded pages"
umherirrender [Fri, 3 Oct 2014 18:44:13 +0000 (20:44 +0200)]
Add comment to AFL_* constants in Defines.php
$wgAntiLockFlags was removed in
Ia709ccdc9addc55c99cbff21a5ff3009b5fbb53c
Change-Id: Ia8685a84b72abb1a86b70f73c3f1e9f0c3e52a8f
James D. Forrester [Sat, 4 Oct 2014 01:51:05 +0000 (18:51 -0700)]
Update OOjs UI to v0.1.0-pre (
48980881f3)
New changes:
aafebc4 LookupInputWidget: Fix whitespace and documentation
cf89618 Element: Remove unneeded IIFE
4898088 build: Create minified JS and CSS distribution files
Change-Id: Iaea30c2429401be4061f30d98a8edc7cce5567b1
jenkins-bot [Sat, 4 Oct 2014 01:23:34 +0000 (01:23 +0000)]
Merge "update-oojs-ui.sh: Exclude the minimised distribution files"
isarra [Sat, 4 Oct 2014 01:03:36 +0000 (01:03 +0000)]
Adjust h3 size to keep it smaller than h2 across normal platforms
Some platforms (especially certain linux distros) use slightly wider
sans-serifs than others by default. Bolding these wider fonts has a
more significant size impact than with narrower ones, so because the
h3 is bold and the h2 is not, a little more distance between their
defined sizes should ensure that the h3 will remain smaller than the
h2 regardless of platform.
Bug: 69999
Change-Id: I667c60f553d67e5208c708446f13b0773ad11ace
jenkins-bot [Fri, 3 Oct 2014 22:20:48 +0000 (22:20 +0000)]
Merge "Html: Use https for @see url of buttonAttributes()"
Prateek Saxena [Fri, 3 Oct 2014 22:07:06 +0000 (15:07 -0700)]
Html: Use https for @see url of buttonAttributes()
Follows up I61bb3c358f755ed9f2153d94b744c1a9da02c456.
Change-Id: I46be4249bdfde1b801e798e732617077f71f983d
jenkins-bot [Fri, 3 Oct 2014 21:57:19 +0000 (21:57 +0000)]
Merge "Use neutral instead of progressive for secondary edit page buttons"
Matthew Flaschen [Fri, 3 Oct 2014 21:44:07 +0000 (17:44 -0400)]
Use neutral instead of progressive for secondary edit page buttons
Only applies if wgUseMediaWikiUIEverywhere is true.
Bug: 71628
Change-Id: Iae6d28e989a7c5b92ba8b31e166aa7b5d3244baf
jenkins-bot [Fri, 3 Oct 2014 21:38:00 +0000 (21:38 +0000)]
Merge "Revert "buttons: Update focus for quiet buttons""
Prtksxna [Fri, 3 Oct 2014 21:18:20 +0000 (21:18 +0000)]
Revert "buttons: Update focus for quiet buttons"
This reverts commit
778ecee16fe38c27c4e313a5bea9c65f6bb65a53.
The implementation of the new design specification
is imperfect. Zooming into the element shows that
the borders aren't equal on all sides and there is
a different colored border on the top and bottom.
Change-Id: Ic8c40498abe9201bdf4e740737467d2d88211442
jenkins-bot [Fri, 3 Oct 2014 21:02:13 +0000 (21:02 +0000)]
Merge "Add comment for messages on 'mediawiki.action.edit.editWarning'"
Florianschmidtwelzow [Fri, 3 Oct 2014 19:19:52 +0000 (21:19 +0200)]
Fix missing mw-ui-button on Login and create page
Don't use modifiers for pages, which uses MW UI nativeley, modifiers
will only be used, when wgUseMediaWikiUIEverywhere is set to true. This
runs into inconsistent use of MWUI on one page.
Follow up: I61bb3c358f755ed9f2153d94b744c1a9da02c456
Bug: 71618
Change-Id: I99d5803818e4c2719f92cab0d9036a1cbc3943ca
umherirrender [Fri, 3 Oct 2014 19:05:29 +0000 (21:05 +0200)]
Add comment for messages on 'mediawiki.action.edit.editWarning'
In I43bf828654d342893a19656ddd4151c2558d2f63 the comment was added for
another usage.
Change-Id: I0510d069c6bc266d8d9e9a144daed2fc8dd7ebb9
kaldari [Fri, 3 Oct 2014 08:31:47 +0000 (01:31 -0700)]
jquery.ui: Collapse border in ui-helper-clearfix
Backport of upstream change released in jQuery UI v1.10.1
* http://bugs.jqueryui.com/ticket/8442
* https://github.com/jquery/jquery-ui/commit/
cb42ee7ccd
This fixes the currently broken display of the media player in the
Listen template on en.wikipedia.org.
Bug: 71601
Change-Id: Ib3e0fc577c3f617955d6d12335a333587c6ddaa8
jenkins-bot [Fri, 3 Oct 2014 18:33:31 +0000 (18:33 +0000)]
Merge "Fix Status serialization with cleanupCallback as Closure"
jenkins-bot [Fri, 3 Oct 2014 18:19:58 +0000 (18:19 +0000)]
Merge "API: Log usage of action=tokens"
jenkins-bot [Fri, 3 Oct 2014 18:08:27 +0000 (18:08 +0000)]
Merge "Turn a wfDebug call in MessageCache::get into a wfDebugLog call"
Brad Jorsch [Fri, 3 Oct 2014 18:06:43 +0000 (14:06 -0400)]
API: Log usage of action=tokens
Change-Id: I5fb7d4e3c7924e61747b652a5cbc3ce0a7ccef01
jenkins-bot [Fri, 3 Oct 2014 18:05:43 +0000 (18:05 +0000)]
Merge "mediawiki.toolbar: Properly deprecate #init"
jenkins-bot [Fri, 3 Oct 2014 18:05:18 +0000 (18:05 +0000)]
Merge "mediawiki.toolbar: Move documentation closer to code"
jenkins-bot [Fri, 3 Oct 2014 17:55:11 +0000 (17:55 +0000)]
Merge "Removed $wgAntiLockFlags to unify the code paths"
jenkins-bot [Fri, 3 Oct 2014 17:45:15 +0000 (17:45 +0000)]
Merge "Avoid attempting to prerender thumbnails that will fail"
Aaron Schulz [Wed, 1 Oct 2014 17:23:00 +0000 (10:23 -0700)]
Removed $wgAntiLockFlags to unify the code paths
Change-Id: Ia709ccdc9addc55c99cbff21a5ff3009b5fbb53c
jenkins-bot [Fri, 3 Oct 2014 17:41:17 +0000 (17:41 +0000)]
Merge "Special:ExpandTemplates: Use MediaWiki UI"
jenkins-bot [Fri, 3 Oct 2014 17:41:10 +0000 (17:41 +0000)]
Merge "Avoid the page join when not really needed"
Florianschmidtwelzow [Fri, 3 Oct 2014 11:49:50 +0000 (13:49 +0200)]
Special:ExpandTemplates: Use MediaWiki UI
Bug: 71433
Change-Id: Ibe965741734bb911813084dad132ece179cc0362
Gilles Dubuc [Fri, 3 Oct 2014 16:09:07 +0000 (18:09 +0200)]
Avoid attempting to prerender thumbnails that will fail
For non-vectorial content, requesting a thumbnail larger than
the original results in a 500. Prerendering in its current form
introduces an increase in 500s that dilutes the real problematic
500s, making troubleshooting harder than it needs to be.
Change-Id: I9418dee7653ad7954c3788ecdd350fc8772edd32
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/301
Brad Jorsch [Fri, 3 Oct 2014 15:57:31 +0000 (11:57 -0400)]
Fix Status serialization with cleanupCallback as Closure
We already have Status objects throw away the cleanupCallback in
__wakeup. Why not also implement __sleep to not save it in the first
place?
The immediate motivation here is that cleanupCallback could be a
Closure, which causes an exception when serialization is attempted (e.g.
when trying to save the Status if an AssembleUploadChunks job fails
verification).
Note this leaves __wakeup intact, in case of old objects where
cleanupCallback is still present in the serialized representation.
Change-Id: I3aa756cd4eb5553ce0b95e7088b929b2f529abfe
jenkins-bot [Fri, 3 Oct 2014 15:41:11 +0000 (15:41 +0000)]
Merge "Made upload jobs avoid using the user session"
jenkins-bot [Fri, 3 Oct 2014 11:56:22 +0000 (11:56 +0000)]
Merge "mediawiki.util: Insert node before updating tooltip for accesskey"
jenkins-bot [Fri, 3 Oct 2014 11:55:06 +0000 (11:55 +0000)]
Merge "mediawiki.util: Clean up nextnode logic"
Bartosz Dziewoński [Sun, 21 Sep 2014 13:26:07 +0000 (15:26 +0200)]
mediawiki.toolbar: Properly deprecate #init
Change-Id: I0271258e5f33b21c68b6224ca74123a3723c9788
Bartosz Dziewoński [Sun, 21 Sep 2014 13:24:29 +0000 (15:24 +0200)]
mediawiki.toolbar: Move documentation closer to code
Also tweaked whitespace and variable naming (b → button).
Change-Id: I52653a7756b3661f4f32985763af03232c873da4
jenkins-bot [Fri, 3 Oct 2014 11:39:10 +0000 (11:39 +0000)]
Merge "Split mediawiki.toolbar from mediawiki.action.edit"
Alexandre Emsenhuber [Mon, 1 Sep 2014 20:26:36 +0000 (22:26 +0200)]
Replace $wgConf->localVHosts by $wgLocalVirtualHosts
The former is independent of the remaining of the SiteConfiguration
class, and as thus makes more sense to be defined as an explicit
configuration setting rather that being hidden in $wgConf.
Change-Id: I25204d37c5cfffb6953fe53e14316dc3df5b5b10
Ori Livneh [Fri, 3 Oct 2014 03:52:05 +0000 (20:52 -0700)]
Turn a wfDebug call in MessageCache::get into a wfDebugLog call
It's a very hot code path, so it makes sense to be able to dive into it in
detail, and having a discrete log bucket makes that easier to do.
Change-Id: I4b547e97711b9e45a99f7b747d785690c70883ec
jenkins-bot [Fri, 3 Oct 2014 00:22:48 +0000 (00:22 +0000)]
Merge "Hygiene: Make construction of buttons easier"
jenkins-bot [Fri, 3 Oct 2014 00:10:37 +0000 (00:10 +0000)]
Merge "Switch custom code to wfParseUrl which covers the same bugfix"
jenkins-bot [Thu, 2 Oct 2014 21:19:38 +0000 (21:19 +0000)]
Merge "Special:MediaStatistics: data-sort-value also for number of files"
jenkins-bot [Thu, 2 Oct 2014 21:18:41 +0000 (21:18 +0000)]
Merge "Added some profiling calls"
jenkins-bot [Thu, 2 Oct 2014 21:12:46 +0000 (21:12 +0000)]
Merge "Removed $wgPageShowWatchingUsers"
jenkins-bot [Thu, 2 Oct 2014 21:12:34 +0000 (21:12 +0000)]
Merge "Improved timestamp precision in ProcessCacheLRU"
jenkins-bot [Thu, 2 Oct 2014 21:12:25 +0000 (21:12 +0000)]
Merge "Bumped the default Swift token expiry a bit"
Translation updater bot [Thu, 2 Oct 2014 21:04:31 +0000 (23:04 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I34e47c0855ee32b67031e1bcbc88f1bab20cdc92
Timo Tijhof [Sun, 21 Sep 2014 03:06:58 +0000 (20:06 -0700)]
Split mediawiki.toolbar from mediawiki.action.edit
Follows-up
285c52039bf4d2f9b.
Get rid of mediawiki.mediawiki.action.toolbar. Not keeping a
backwards-compat alias since this module is not supposed to be used
publicly in its current form.
Change-Id: I403216c6916e1f4d29216a55c3fe6c92eb68400b
jenkins-bot [Thu, 2 Oct 2014 20:27:51 +0000 (20:27 +0000)]
Merge "Don't rely on $wgTitle in WebRequest"
umherirrender [Thu, 2 Oct 2014 20:20:55 +0000 (22:20 +0200)]
Special:MediaStatistics: data-sort-value also for number of files
The column "Number of files" is sortable, but does not contains plain
numbers, so it needs a data-sort-value to allow js to sort correct.
Change-Id: I9b7232b755dc8dab2cf04682103085273dada737
Aaron Schulz [Thu, 2 Oct 2014 17:22:27 +0000 (10:22 -0700)]
Avoid the page join when not really needed
* That sometimes triggered a filesorts when the title for the
inequality has certain (seemingly long) values.
* Also made the continuation queries use > instead of >=.
Change-Id: I912df77ad43f025918e52d1494300d487a9deea1
Gilles Dubuc [Thu, 2 Oct 2014 15:26:37 +0000 (17:26 +0200)]
Switch custom code to wfParseUrl which covers the same bugfix
Change-Id: I60b20bd7e8f4b25acd5ef2de172786a152c0e589
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/301
jenkins-bot [Thu, 2 Oct 2014 08:39:45 +0000 (08:39 +0000)]
Merge "Set content language for ContentHandlerTest::testGetAutosummary"
jenkins-bot [Thu, 2 Oct 2014 07:02:44 +0000 (07:02 +0000)]
Merge "Make submit of Special:NewFiles progressive"
jenkins-bot [Thu, 2 Oct 2014 06:00:50 +0000 (06:00 +0000)]
Merge "Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled"
Matthew Flaschen [Thu, 2 Oct 2014 05:06:46 +0000 (01:06 -0400)]
Make submit of Special:NewFiles progressive
Bug: 71445
Change-Id: Iba2a8e7f37c2c1af3a018740d5a9b48edc84e238
jenkins-bot [Thu, 2 Oct 2014 04:24:18 +0000 (04:24 +0000)]
Merge "Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class"
Shahyar [Fri, 22 Aug 2014 23:50:43 +0000 (16:50 -0700)]
Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class
Introduced mw-ui-text base class for plain-text, non-interactable elements which require context colors (eg. icons)
Also added mw-ui-anchor for interactable elements (such as anchors)
Note: This is not supported by IE6 at current time.
Bug: 69212
Bug: 70801
Change-Id: I4d017d0a22cb4f3ca52b6228e45c0463c110ae64
jenkins-bot [Thu, 2 Oct 2014 01:04:41 +0000 (01:04 +0000)]
Merge "API: Fix ApiQueryBacklinks logic and use *_from_namespace"
Fomafix [Sun, 13 Jul 2014 14:59:10 +0000 (14:59 +0000)]
mediawiki.util: Insert node before updating tooltip for accesskey
updateTooltipAccessKeys() uses the native accessKeyLabel property which,
in Firefox, isn't available until after the node is inserted into the
document.
Bug: 67946
Change-Id: I3b80174e2f5df1c9082d30607dbe9b63ede6b5b5
Timo Tijhof [Wed, 1 Oct 2014 23:12:55 +0000 (16:12 -0700)]
mediawiki.util: Clean up nextnode logic
Change-Id: I21469a765002897f03caca97628ad36264d49c83
Aaron Schulz [Mon, 29 Sep 2014 23:53:26 +0000 (16:53 -0700)]
Loosened the CLI restriction in RequestContext::importScopedSession()
* Jobs can be run via HTTP runners rather than just CLI ones.
The old check breaks jobs run on HHVM fcgi runners for example.
* Always check the validity of the IP for sanity.
Change-Id: I1d03c2ab6628b2d124bc7b9f6936788dea22e3e4
jenkins-bot [Wed, 1 Oct 2014 21:55:30 +0000 (21:55 +0000)]
Merge "Fix SpecialPageFactory list handling"
jenkins-bot [Wed, 1 Oct 2014 21:41:04 +0000 (21:41 +0000)]
Merge "Remove $wgGoToEdit functionality"
jenkins-bot [Wed, 1 Oct 2014 21:40:57 +0000 (21:40 +0000)]
Merge "Avoid stupid mariadb filesort in findMissingFiles.php"
jenkins-bot [Wed, 1 Oct 2014 21:24:49 +0000 (21:24 +0000)]
Merge "Workaround for thumbnail pre rendering with PHP < 5.4.7"
Aaron Schulz [Wed, 1 Oct 2014 21:21:26 +0000 (14:21 -0700)]
Avoid stupid mariadb filesort in findMissingFiles.php
Change-Id: I6267cfaf375fcc0eea8291fd7a2a0f7daa05a941
Gilles Dubuc [Wed, 1 Oct 2014 20:55:23 +0000 (22:55 +0200)]
Workaround for thumbnail pre rendering with PHP < 5.4.7
Since this code is dealing with scheme-less URLs, parse_url()
can cause issues in older versions of PHP.
Change-Id: Ic1276feed9ed51772a05c4a73c787a315b848066
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/301
Timo Tijhof [Thu, 11 Sep 2014 23:14:16 +0000 (18:14 -0500)]
SECURITY: OutputPage: Remove separation of css and js module allowance
* No longer segment module origin allowance by an "only=" content
type. Both can be sensitive security-wise and there's no valid
use case for allowing CSS anywhere you want to disallow JS. Both
can significantly impact the user interface and cause unintended
actions to be taken on the user's behalf, or desired actions to
be made practically impossible.
* While at it, also remove the ability to set the module allowance
directly. The reduceAllowedModuleOrigin method is all we need.
I couldn't find usage or mention of setAllowedModules() in
mediawiki-core nor in any other Wikimedia-hosted repository.
Bug: 70672
Change-Id: I308e794daca27a9380c67be350f8ab51f9c2de34
Brad Jorsch [Thu, 21 Aug 2014 17:39:27 +0000 (13:39 -0400)]
API: Fix ApiQueryBacklinks logic and use *_from_namespace
The original intent of this patch was to have ApiQueryBacklinks use the
*_from_namespace fields added in Icca99b6a. It does that, but in the
process several other bugs were found in the module:
* Continuation could skip pages when blredirect was used.
* The result object would be populated incorrectly if
$wgAPIMaxResultSize was hit and blredirect was used.
* Continuation could (probably) skip or (maybe) repeat pages when
blredirect was used and $wgAPIMaxResultSize was hit.
In the process of analyzing and fixing these problems, the code was
heavily refactored.
Change-Id: I32381c0f082d2f8e063af99ee353ae003c163c23
Translation updater bot [Wed, 1 Oct 2014 19:47:44 +0000 (21:47 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id353e6c005c2cd58d7b1aa18dbd5638d8221cf1b
umherirrender [Sat, 27 Sep 2014 09:53:02 +0000 (11:53 +0200)]
Set content language for ContentHandlerTest::testGetAutosummary
This test depends on content language when comparing to a english
message text.
Change-Id: Ic50c0b6a821fb1d51d70119fbf712a18b73ce4c8
Kevin Israel [Tue, 24 Jun 2014 07:14:24 +0000 (03:14 -0400)]
Special:BookSources: Correct validation of ISBNs containing X
PHP's "equal" (==) operator considers the integer 0 to be equal to
the string 'X', and when 'X' is converted to a number, it becomes 0.
Neither is desired here.
* Fail when an X is encountered while calculating the check digit.
(X can only occur as the check digit of an ISBN-10.)
* Fixed the check digit comparisons by adding an explicit string cast.
* Used the "identical" operator to make it more obvious that no type
juggling should take place during the comparisons.
* Added some test cases.
* Removed an outdated TODO.
Bug: 67021
Change-Id: I85f53c41f403a60340e9441757fe66b9764e623c
This, that and the other [Sun, 27 Jul 2014 11:02:59 +0000 (21:02 +1000)]
Preserve log comment text field value across import attempts
This was first attempted way back in r45340, but was reverted in r45489.
Bug: 16793
Change-Id: Ieb9fb7e7e918b2e7e2b8289b3fdf82a49ea75a17
Brad Jorsch [Wed, 1 Oct 2014 03:20:04 +0000 (23:20 -0400)]
Fix SpecialPageFactory list handling
* Since Ic917c7d8/I7420b9ec, SpecialPageFactory doesn't properly cache
SpecialPageFactory::$list.
* SpecialPageFactory::resetList() has never really worked right, it
loses all the core special pages.
* SpecialPageFactory::getAliasListObject() could be called recursively
from a SpecialPage_initList hook. There's no particular reason to fail
it, just allow the original call to override the result of the
recursive one and hope it works.
Change-Id: I7adb346eab00d5849d087ddff75230a35be3ee8f