From: Kunal Mehta <legoktm@member.fsf.org>
Date: Sat, 2 Jun 2018 02:14:02 +0000 (-0700)
Subject: Skip MediaWikiTestCaseSchema1Test on Postgres
X-Git-Tag: 1.34.0-rc.0~4955
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dmes_infos.php?a=commitdiff_plain;h=e1990c6f0e1edc0379e2626c6e6ff5f0a2511233;p=lhc%2Fweb%2Fwiklou.git

Skip MediaWikiTestCaseSchema1Test on Postgres

According to Anomie, the idea behind this test is semi-broken, and would
benefit from T191231 being implemented first.

Bug: T195807
Change-Id: I9561fd0a82c37cf044e292e00499ecb611fcded6
---

diff --git a/tests/phpunit/tests/MediaWikiTestCaseSchema1Test.php b/tests/phpunit/tests/MediaWikiTestCaseSchema1Test.php
index d794d1318a..aebd0bf10e 100644
--- a/tests/phpunit/tests/MediaWikiTestCaseSchema1Test.php
+++ b/tests/phpunit/tests/MediaWikiTestCaseSchema1Test.php
@@ -11,6 +11,13 @@ class MediaWikiTestCaseSchema1Test extends MediaWikiTestCase {
 
 	public static $hasRun = false;
 
+	public function setUp() {
+		parent::setUp();
+		if ( $this->db->getType() == 'postgres' ) {
+			$this->markTestSkipped( __CLASS__ . ' does not support postgres' );
+		}
+	}
+
 	public function getSchemaOverrides( IMaintainableDatabase $db ) {
 		return [
 			'create' => [ 'MediaWikiTestCaseTestTable', 'imagelinks' ],
diff --git a/tests/phpunit/tests/MediaWikiTestCaseSchema2Test.php b/tests/phpunit/tests/MediaWikiTestCaseSchema2Test.php
index 5464dc43f8..c0673a10dc 100644
--- a/tests/phpunit/tests/MediaWikiTestCaseSchema2Test.php
+++ b/tests/phpunit/tests/MediaWikiTestCaseSchema2Test.php
@@ -14,6 +14,13 @@
  */
 class MediaWikiTestCaseSchema2Test extends MediaWikiTestCase {
 
+	public function setUp() {
+		parent::setUp();
+		if ( $this->db->getType() == 'postgres' ) {
+			$this->markTestSkipped( __CLASS__ . ' does not support postgres' );
+		}
+	}
+
 	public function testMediaWikiTestCaseSchemaTestOrder() {
 		// The first test must have run before this one
 		$this->assertTrue( MediaWikiTestCaseSchema1Test::$hasRun );