From: csteipp <csteipp@wikimedia.org>
Date: Sat, 29 Mar 2014 05:39:57 +0000 (-0700)
Subject: SECURITY: escape sortKey in pageInfo
X-Git-Tag: 1.31.0-rc.0~16029^2
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dmes_infos.php?a=commitdiff_plain;h=0b695ae09aada343ab59be4a3c9963995a1143b6;p=lhc%2Fweb%2Fwiklou.git

SECURITY: escape sortKey in pageInfo

DEFAULTSORT isn't escaped before being added to the action=info table.

Bug: 63251
Change-Id: I087bfde8cbc69c3507f68ee3cb6e22aba0ffa7db
---

diff --git a/includes/actions/InfoAction.php b/includes/actions/InfoAction.php
index 06e36676b3..6b254603d3 100644
--- a/includes/actions/InfoAction.php
+++ b/includes/actions/InfoAction.php
@@ -262,6 +262,7 @@ class InfoAction extends FormlessAction {
 			$sortKey = $pageProperties['defaultsort'];
 		}
 
+		$sortKey = htmlspecialchars( $sortKey );
 		$pageInfo['header-basic'][] = array( $this->msg( 'pageinfo-default-sort' ), $sortKey );
 
 		// Page length (in bytes)