Merge "Don't throw exceptions in ContentHandler::getUndoContent()"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 8 Sep 2016 05:07:13 +0000 (05:07 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 8 Sep 2016 05:07:13 +0000 (05:07 +0000)
includes/content/ContentHandler.php

index 22db08a..9ea4f40 100644 (file)
@@ -1018,9 +1018,15 @@ abstract class ContentHandler {
                        return false; // no content to undo
                }
 
-               $this->checkModelID( $cur_content->getModel() );
-               $this->checkModelID( $undo_content->getModel() );
-               $this->checkModelID( $undoafter_content->getModel() );
+               try {
+                       $this->checkModelID( $cur_content->getModel() );
+                       $this->checkModelID( $undo_content->getModel() );
+                       $this->checkModelID( $undoafter_content->getModel() );
+               } catch ( MWException $e ) {
+                       // If the revisions have different content models
+                       // just return false
+                       return false;
+               }
 
                if ( $cur_content->equals( $undo_content ) ) {
                        // No use doing a merge if it's just a straight revert.