performInstallation() should halt when a fatal status is encountered
authorChad Horohoe <demon@users.mediawiki.org>
Wed, 7 Jul 2010 12:48:20 +0000 (12:48 +0000)
committerChad Horohoe <demon@users.mediawiki.org>
Wed, 7 Jul 2010 12:48:20 +0000 (12:48 +0000)
includes/installer/Installer.php

index 7a84488..5efdc0c 100644 (file)
@@ -884,6 +884,11 @@ abstract class Installer {
                        }
                        call_user_func_array( $endCB, array( $step, $status ) );
                        $installResults[$step] = $status;
+
+                       // If we've hit some sort of fatal, we need to bail. Callback
+                       // already had a chance to do output above.
+                       if( !$status->isOk() )
+                               break;
                }
                return $installResults;
        }