actions: Avoid use of is_null() PHP function where necessary
authorDerick Alangi <alangiderick@gmail.com>
Fri, 11 Jan 2019 15:40:27 +0000 (16:40 +0100)
committerDerick Alangi <alangiderick@gmail.com>
Fri, 11 Jan 2019 15:40:27 +0000 (16:40 +0100)
WRT performance, is_null() is a few nanoseconds slower than === null
due to function call overhead. Also, I personally think using the
identical check on null is slightly more readable than using is_null().

Change-Id: Ie5b1ac17a18907e92eb3042decb7fc75e903123d

includes/actions/HistoryAction.php

index d6b8057..fdf4f85 100644 (file)
@@ -511,7 +511,7 @@ class HistoryPager extends ReverseChronologicalPager {
                        if ( $row->rev_parent_id ) {
                                $revIds[] = $row->rev_parent_id;
                        }
-                       if ( !is_null( $row->user_name ) ) {
+                       if ( $row->user_name !== null ) {
                                $batch->add( NS_USER, $row->user_name );
                                $batch->add( NS_USER_TALK, $row->user_name );
                        } else { # for anons or usernames of imported revisions