Remove pointless rollback() warnings with "flush"
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 13 Jan 2016 15:00:42 +0000 (07:00 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 13 Jan 2016 15:00:45 +0000 (07:00 -0800)
This would previously make log noise when rollbackMasterChangesAndLog()
is triggered for explicit transactions.

Change-Id: Ia0009bcf575ef346d3bb7354ce3fb6fb477eb95f

includes/db/Database.php

index 6e1b8a9..c58e9bd 100644 (file)
@@ -2689,8 +2689,6 @@ abstract class DatabaseBase implements IDatabase {
                } else {
                        if ( !$this->mTrxLevel ) {
                                return; // nothing to do
-                       } elseif ( !$this->mTrxAutomatic ) {
-                               wfWarn( "$fname: Flushing an explicit transaction, getting out of sync!" );
                        }
                }