rdbms: do not silently rollback empty transactions on error
authorAaron Schulz <aschulz@wikimedia.org>
Sun, 22 Apr 2018 22:38:49 +0000 (15:38 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 30 May 2018 03:10:02 +0000 (03:10 +0000)
commit0b5ed025e97700d4d9c23e2978d9c9e14bc8b7fe
tree7062cd727fe3b9a95410c439570b7d6e9ba099f0
parent60ee1e81108b1f1a691ac67aa6f7f118a5788c0f
rdbms: do not silently rollback empty transactions on error

Since there might be important view snapshots, temp tables, or effects
from SET statements or the like, go into TRX_ERROR state for "possible
transaction level errors" even if no recognized writes took place and
the transaction was not explicit.

Change-Id: I32c34bc28b845e343d0167a220412824838eaed8
includes/libs/rdbms/database/Database.php
tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php