Tim Starling [Tue, 23 Oct 2012 05:00:37 +0000 (16:00 +1100)]
Fix SpecialPage::isRestricted()
Fix SpecialPage::isRestricted(), broken by I41edb091 (
22dd67e) which
inverted the group permission check. Seems to only affect
Special:SpecialPages. Bug 41294.
Change-Id: I8685eaeb4a688cc8e205afdb1639c08e4a2bd3da
Krinkle [Mon, 22 Oct 2012 21:18:32 +0000 (21:18 +0000)]
Merge "* (bug 41267) mediawiki.action.edit.preview is not loaded"
GWicke [Mon, 22 Oct 2012 20:46:52 +0000 (20:46 +0000)]
Merge "Add additional specs + Parsoid-centric tests to keep Parsoid in line."
Reedy [Mon, 22 Oct 2012 19:04:15 +0000 (19:04 +0000)]
Merge "check for null content in ApiParse.php"
aude [Mon, 22 Oct 2012 18:48:09 +0000 (18:48 +0000)]
check for null content in ApiParse.php
Change-Id: I32b3c02163f2295f91b680e3a5636105960b971a
Translation updater bot [Mon, 22 Oct 2012 18:44:59 +0000 (18:44 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I6cbab03f0e9af894789a03879afda65aec946f8f
Siebrand [Mon, 22 Oct 2012 18:12:53 +0000 (18:12 +0000)]
Merge "Use Html class instead of Xml where possible in Special:Contributions"
Aaron Schulz [Mon, 22 Oct 2012 17:41:43 +0000 (10:41 -0700)]
[FileBackend] Give warnings when metadata is missing from swift.
Change-Id: I2ec2429c5fca02fbd8b5130b3f0db31faf6e365e
Alexandre Emsenhuber [Wed, 10 Oct 2012 19:35:42 +0000 (21:35 +0200)]
Use Html class instead of Xml where possible in Special:Contributions
Also simplified the code by using Html::rawElement() instead of
openElement() and closeElement() and added some lines breaks to
the output for better readability.
Change-Id: Ie7ce5c65ba34b30799580acda0a9d82eb38d257f
Reedy [Mon, 22 Oct 2012 16:49:14 +0000 (17:49 +0100)]
* (bug 41267) mediawiki.action.edit.preview is not loaded
Change-Id: Icfea6f25416ba276ebca5e095e37155a945b8492
Siebrand [Mon, 22 Oct 2012 12:06:57 +0000 (12:06 +0000)]
Merge "Use Linker::link() instead of Linker::linkKnown() when having options"
Siebrand [Mon, 22 Oct 2012 12:06:10 +0000 (12:06 +0000)]
Merge "Setting $wgContLang without changing $wgLanguageCode accordingly is a very bad idea."
Siebrand [Mon, 22 Oct 2012 12:04:49 +0000 (12:04 +0000)]
Merge "doxygen now recognizes README and .txt files"
Antoine Musso [Mon, 22 Oct 2012 10:29:52 +0000 (12:29 +0200)]
miscellaneous doxygen warnings
* @licence -> @license
* Protects inline HTML by using double quotes, our inline comments uses
elements such as <h1> or <firstnameLastname@gmail.com>
* Commands in lowercase (@TODO -> @todo, @NOTE -> @note)
* removes @abstract and @static since doxygen detects them from PHP
code.
* various undocumented function parameters
* typos in parameters declarations
Change-Id: I62ad6fc124c355bf31acc780b9614a59cf79a421
Antoine Musso [Mon, 22 Oct 2012 09:57:49 +0000 (11:57 +0200)]
doxygen now recognizes README and .txt files
The default doxygen configuration file only accepts source files such
as php or python. Some of our documentation is in flat files which we
might want to include in our Doxygen inline documentation. The culprit
is that those document files needs to respect Doxygen syntax, i.e. the
text content need to be enclosed in a comment block such as:
/*!
\page page_title My Page Title
My awesome documentation
*/
Doyxgen 1.8 supports markdown syntax, we might want to switch to that
eventually.
Change-Id: I78a0ce36314b2a7b9f89395e3ae3902b17cf5038
Translation updater bot [Sun, 21 Oct 2012 23:59:55 +0000 (23:59 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I0455c85c4e5166a3520eee90cf4fa0aaa0e170cd
Tim Starling [Sun, 21 Oct 2012 22:43:46 +0000 (09:43 +1100)]
Restore executable bit to bin/ulimit4.sh
Restore executable bit to bin/ulimit4.sh, accidentally wiped in the
Wikidata (ContentHandler) branch.
Change-Id: I49696bce45bbc3f362a6560ace38797c566930c1
IAlex [Sun, 21 Oct 2012 18:04:36 +0000 (18:04 +0000)]
Merge "When deleting old thumbnails, actually increment $i"
IAlex [Sun, 21 Oct 2012 17:58:59 +0000 (17:58 +0000)]
Merge "Cache performer of a LogEntry to load it only once from the database"
IAlex [Sun, 21 Oct 2012 17:47:35 +0000 (17:47 +0000)]
Merge "RecentChangesLinked: 'tagfilter' option already set in parent"
IAlex [Sun, 21 Oct 2012 17:10:38 +0000 (17:10 +0000)]
Merge "CologneBlue rewrite: fix talkLink() to use generic nav links"
MatmaRex [Fri, 5 Oct 2012 18:13:15 +0000 (20:13 +0200)]
CologneBlue rewrite: fix talkLink() to use generic nav links
* introduce processNavlinkForDocument() for repeated links
* remove wfFindFile() check for NS_FILE namespace: Linker::link() already
checks this
* redo the way the message for the link is selected
* comment everything
Change-Id: Ibeb0a1bfa1f34b9fdd9f6e5f082d6973d1ba09b9
umherirrender [Sun, 21 Oct 2012 15:57:54 +0000 (17:57 +0200)]
Cache performer of a LogEntry to load it only once from the database
Change-Id: If920ba0a29b8c9b04705a20db5d8f9528b251fe5
Reedy [Sun, 21 Oct 2012 15:51:34 +0000 (15:51 +0000)]
Merge "Add wfSuppressWarnings(); to CologneBlue."
umherirrender [Sun, 21 Oct 2012 15:26:23 +0000 (17:26 +0200)]
RecentChangesLinked: 'tagfilter' option already set in parent
Inside SpecialRecentChanges::getDefaultOptions() the 'tagfilter' option
is already set, so there is no need to do it a second time.
Change-Id: If89cf65a19676a4c6efa82883544b74e08961c62
Reedy [Sun, 21 Oct 2012 14:14:10 +0000 (15:14 +0100)]
When deleting old thumbnails, actually increment $i
Change-Id: Ic213fed61959ab4d25bcd891c81df20e39cbc5f5
IAlex [Sun, 21 Oct 2012 12:54:28 +0000 (12:54 +0000)]
Merge "don't overwrite $item['single-id'] in makeListItem in SkinTemplate"
Translation updater bot [Sat, 20 Oct 2012 22:55:11 +0000 (22:55 +0000)]
Merge changes I5f84fd91,I34ea53e7
* changes:
Localisation updates from http://translatewiki.net.
Localisation updates from http://translatewiki.net.
Translation updater bot [Sat, 20 Oct 2012 22:40:04 +0000 (22:40 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I5f84fd918fdedd46ee623957cfe62f402ef8c3cb
Translation updater bot [Sat, 20 Oct 2012 20:12:27 +0000 (20:12 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I34ea53e767a3488b9f6ff003d3bba43938149296
IAlex [Sat, 20 Oct 2012 20:05:45 +0000 (20:05 +0000)]
Merge "(bug 40857) fix non-array sidebar links handling in CologneBlue"
MatmaRex [Sat, 20 Oct 2012 17:52:41 +0000 (19:52 +0200)]
add comments about the purpose of skins/common/common*.css files
Per Dantman's (Daniel Friesen) comments on
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/95837.
Also a little cleanup in the header comments.
Change-Id: I8bc5d591ade631b9bb030e8ab6e102fd3146247a
Alexandre Emsenhuber [Sat, 20 Oct 2012 16:15:18 +0000 (18:15 +0200)]
Setting $wgContLang without changing $wgLanguageCode accordingly is a very bad idea.
This caused about 200 exceptions "MWException: Error in MediaWikiLangTestCase::setUp(): $wgLanguageCode ('fr') is different from $wgContLang->getCode() (en)" on my installation.
Change-Id: I2987db68e22b27d8d36cdae118356fd7612e56a4
IAlex [Sat, 20 Oct 2012 16:13:42 +0000 (16:13 +0000)]
Merge "(bug 41171) Refactor User::edits() and User::incEditCount()"
IAlex [Sat, 20 Oct 2012 16:04:51 +0000 (16:04 +0000)]
Merge "Unit test for User::getEditCount"
IAlex [Sat, 20 Oct 2012 14:47:08 +0000 (14:47 +0000)]
Merge "Add filearchive.fa_sha1 to PostgreSQL as well."
IAlex [Sat, 20 Oct 2012 14:40:55 +0000 (14:40 +0000)]
Merge "Remove a bunch of trailing spaces and unneeded newlines"
IAlex [Sat, 20 Oct 2012 14:38:03 +0000 (14:38 +0000)]
Merge "Remove a bunch of trailing spaces and unneeded newlines"
Nikerabbit [Sat, 20 Oct 2012 14:03:52 +0000 (14:03 +0000)]
Merge "Bug 41234 - api prop=imageinfo broken on PHP 5.4"
umherirrender [Sat, 20 Oct 2012 11:35:38 +0000 (13:35 +0200)]
Remove a bunch of trailing spaces and unneeded newlines
Change-Id: If9fb04f64389b9b40c13f3372ad4792c2e14def0
umherirrender [Sat, 20 Oct 2012 11:32:35 +0000 (13:32 +0200)]
Remove a bunch of trailing spaces and unneeded newlines
Change-Id: I52ae3c55044bc8c53698e356bad74969406670bf
IAlex [Sat, 20 Oct 2012 06:25:29 +0000 (06:25 +0000)]
Merge "Remove a bunch of trailing spaces and unneeded newlines"
IAlex [Sat, 20 Oct 2012 06:21:31 +0000 (06:21 +0000)]
Merge "Remove a bunch of trailing spaces and unneeded newlines"
Tim Landscheidt [Sat, 20 Oct 2012 03:36:03 +0000 (03:36 +0000)]
Add filearchive.fa_sha1 to PostgreSQL as well.
This fixes bug #41114.
Change-Id: I021070f90d35d99ad55944543e94004f62d5f08c
Reedy [Sat, 20 Oct 2012 02:23:27 +0000 (03:23 +0100)]
Bug 41234 - api prop=imageinfo broken on PHP 5.4
Fix by Roan
Change-Id: I14d8da45f7655ded501e3dd48dbdd424ecacc885
Ori Livneh [Fri, 19 Oct 2012 19:02:11 +0000 (12:02 -0700)]
getParamValue defaults to current page only if url undefined
The danger of using || here is apparent if you consider the
following case:
mw.util.getParamValue( 'action', document.referrer );
If document.referrer is the empty string (as it often is),
getParamValue will look up the 'action' parameter in the
current URL, which is surely unintended. The solution is to
use the default value if and only if the url parameter is
undefined.
Change-Id: Ifd949f890d2f974dacc40e549c820c434ce57f53
Reedy [Fri, 19 Oct 2012 23:17:59 +0000 (00:17 +0100)]
A few more for bug 41122
Change-Id: I756067c8e40eafff87f8f448a9e037228afd3bf3
Subramanya Sastry [Fri, 19 Oct 2012 22:22:18 +0000 (17:22 -0500)]
Add additional specs + Parsoid-centric tests to keep Parsoid in line.
Change-Id: I9a6970b13d6f76d1f740655b3ff5061b6edad32f
Reedy [Fri, 19 Oct 2012 22:11:58 +0000 (22:11 +0000)]
Merge "Revert "Revert "Show a "(blocked)" hint on Special:ListUsers/ActiveUsers"""
Translation updater bot [Fri, 19 Oct 2012 20:29:41 +0000 (20:29 +0000)]
Merge "Localisation updates from translatewiki.net."
Reedy [Fri, 19 Oct 2012 20:12:55 +0000 (21:12 +0100)]
Bug 41122 - Catchable fatal error: Object of class ParserOptions could not be converted to string
Fix ApiParse occurence
Change-Id: I82db8bb6dff178e11a1e6731fbf2cd977daa804a
umherirrender [Fri, 19 Oct 2012 20:10:42 +0000 (22:10 +0200)]
Remove a bunch of trailing spaces and unneeded newlines
Change-Id: I166a171c196f4c2c75886be12f913ffa9a4a35ad
umherirrender [Fri, 19 Oct 2012 20:03:05 +0000 (22:03 +0200)]
Remove a bunch of trailing spaces and unneeded newlines
Change-Id: I7db616db8c969567d420c0161fa207b366e292b6
Translation updater bot [Fri, 19 Oct 2012 20:01:49 +0000 (20:01 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I30c902e8570c74138b0e90e6d90dda7be8b760a0
Nikerabbit [Fri, 19 Oct 2012 19:38:14 +0000 (19:38 +0000)]
Merge "Fixed dependencies for jquery.collapsibleTabs"
Aaron Schulz [Fri, 19 Oct 2012 19:28:08 +0000 (12:28 -0700)]
[FileBackend] Issue a warnings for cache problems in streamFile().
Change-Id: I62cf6f07dc8722d483b3b6969aae1915c4ffccc6
IAlex [Fri, 19 Oct 2012 19:15:42 +0000 (19:15 +0000)]
Merge "(bug 41156) Add id to the toolbox page info link"
Reedy [Fri, 19 Oct 2012 17:18:43 +0000 (17:18 +0000)]
Revert "Revert "Show a "(blocked)" hint on Special:ListUsers/ActiveUsers""
This reverts commit
79a72a34c4ac525afa81d7c2ccfdefbc13a7dc92
Hashar [Fri, 19 Oct 2012 13:43:42 +0000 (13:43 +0000)]
Merge "(bug 40876) Icon for PSD (Adobe Photoshop) file types."
Reedy [Fri, 19 Oct 2012 13:41:49 +0000 (13:41 +0000)]
Merge "(Bug 41178) Check whether content is null or false."
ankur [Sat, 13 Oct 2012 06:24:02 +0000 (11:54 +0530)]
(bug 40876) Icon for PSD (Adobe Photoshop) file types.
The icon comes from the KDE "crystal svg" icon collection.
Change-Id: Ieac947391629e14980d1b81f5cef8bc20a15c01a
daniel [Mon, 15 Oct 2012 15:27:34 +0000 (17:27 +0200)]
Add some debug logging to ContentHandler
Change-Id: I3f728999bc0576e4d225b49b5440a7fc5617d52d
jeroendedauw [Tue, 16 Oct 2012 18:00:15 +0000 (20:00 +0200)]
Release note for ApiQueryORM class
The class let you facilitate the creation of query API modules.
Change-Id: I30485076edd59edf02b90fc394a710c6353ee898
Reedy [Thu, 18 Oct 2012 12:19:59 +0000 (13:19 +0100)]
Revert excessive indenting from 28433
Also remove indenting from else statement in the same block
Change-Id: I571880a4404fbc5a4804de9d3e2eb8f9d1501a37
Tim Landscheidt [Fri, 19 Oct 2012 03:02:20 +0000 (03:02 +0000)]
Protect against Xdebug overloading var_dump().
This fixes bug #36452.
Change-Id: I0fc65af8c561b23daa5301a00706acb5b3f619dc
daniel [Fri, 19 Oct 2012 10:24:49 +0000 (12:24 +0200)]
(Bug 41178) Check whether content is null or false.
This is a follow-up to I7d629753.
Change-Id: Id9e307fcbab5d28fe4fc4ec21b5a4882cffc6841
Nikerabbit [Fri, 19 Oct 2012 08:07:26 +0000 (08:07 +0000)]
Merge "Updated release notes for job queue refactoring."
Nikerabbit [Fri, 19 Oct 2012 07:32:52 +0000 (07:32 +0000)]
Merge "Fixup some returns, documentation"
IAlex [Fri, 19 Oct 2012 05:55:30 +0000 (05:55 +0000)]
Merge "Avoid using $wgUser in TitlePermissionTest"
Tim Starling [Fri, 19 Oct 2012 03:02:39 +0000 (14:02 +1100)]
Clear $this->mOptionsLoaded in User::clearInstanceCache()
(bug 41198) If clearInstanceCache() is to clear cached user data apart
from the data from the user table, as addToDatabase() expects, then
$this->mOptionsLoaded needs to be set to false. Clearing $this->mOptions
may reduce memory usage a bit, but is not sufficient.
Change-Id: I6912415dc154d06f62839a1ee777c2c3747253d6
Aaron Schulz [Thu, 18 Oct 2012 21:58:32 +0000 (14:58 -0700)]
[FileBackend] Clear persistent stat cache if it mislead streamFile().
Change-Id: Ie02e9e0c56180d8cbd2507b795cd960f3ba84f33
aude [Thu, 18 Oct 2012 21:33:34 +0000 (23:33 +0200)]
fix bug 41122, provide missing revId param in ApiQueryRevisions
Change-Id: I8e6b4f845f15bb230965e0e765fdc0f15f67c014
Aaron Schulz [Thu, 18 Oct 2012 21:19:08 +0000 (14:19 -0700)]
Updated release notes for job queue refactoring.
Change-Id: Icfc62496f58e3e9fa142f24c9d3f2e96fce698d0
Demon [Thu, 18 Oct 2012 20:05:45 +0000 (20:05 +0000)]
Merge "[FileBackend] Cleaned up path normalization for caching."
Aaron Schulz [Thu, 18 Oct 2012 19:54:37 +0000 (12:54 -0700)]
Removed outdated FileRepo docs.
Change-Id: I020960028be12b87fe572eb3f56e4b33f517c495
Translation updater bot [Thu, 18 Oct 2012 19:35:16 +0000 (19:35 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Thu, 18 Oct 2012 19:18:08 +0000 (19:18 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Iab323e87d18f24f31808cff0d9e0510cb79e4260
Reedy [Thu, 18 Oct 2012 19:14:30 +0000 (19:14 +0000)]
Merge "Make EditPage robust against null content."
Aaron Schulz [Thu, 18 Oct 2012 18:45:12 +0000 (11:45 -0700)]
[FileBackend] Cleaned up path normalization for caching.
Change-Id: I50a9f80ce6268526043485bb662557667442cffb
Reedy [Thu, 18 Oct 2012 19:10:52 +0000 (19:10 +0000)]
Merge "(Bug 41179) Missing content in EditPage::showDiff"
Reedy [Thu, 18 Oct 2012 19:10:05 +0000 (19:10 +0000)]
Merge "(Bug 41178) Fix fatal in EditPage::displayPermissionsError."
Demon [Thu, 18 Oct 2012 18:45:36 +0000 (18:45 +0000)]
Merge "(Bug 41169) Apply rtrim on on preSaveTransfrom."
daniel [Thu, 18 Oct 2012 18:14:46 +0000 (20:14 +0200)]
(Bug 41169) Apply rtrim on on preSaveTransfrom.
Wikitext should not have trailing whitespace.
Change-Id: I75eb1c4bef7217ec2b7440594e3fc4b68dc3c022
Alex Monk [Thu, 18 Oct 2012 18:37:32 +0000 (19:37 +0100)]
(bug 41156) Add id to the toolbox page info link
Change-Id: I4295d88f17aa468370af432e0b980e56c4581084
Demon [Thu, 18 Oct 2012 18:37:24 +0000 (18:37 +0000)]
Merge "[FileBackend] Added more tests and fixed some local copy/reference bugs."
Aaron Schulz [Thu, 18 Oct 2012 18:35:48 +0000 (18:35 +0000)]
Merge "Followup I15843fab: don't show &page=1 in file link"
Demon [Thu, 18 Oct 2012 18:31:10 +0000 (18:31 +0000)]
Merge "[Bug 41155] Record links on CSS/JS pages in the DB."
daniel [Thu, 18 Oct 2012 13:21:34 +0000 (15:21 +0200)]
[Bug 41155] Record links on CSS/JS pages in the DB.
ContentHandler removed wikitext parsing for CSS and JS pages.
However, people seem to rely on links and categories embedded
in script comments.
Change-Id: I0736f15878fbd3292e75854bf16f04df656ce363
daniel [Thu, 18 Oct 2012 17:51:49 +0000 (19:51 +0200)]
Make EditPage robust against null content.
This adds some checks to avoid fatal errors due to access
to non-objects.
Change-Id: Ib0e867a9aed50226fa8c6f3af655cd11e7fb83ed
Reedy [Thu, 18 Oct 2012 17:43:12 +0000 (18:43 +0100)]
Fixup some returns, documentation
Remove unused globals
Fix indenting
Change-Id: Icb9fad6ae5407260d56c790bf22d556436c32ea5
daniel [Thu, 18 Oct 2012 17:37:26 +0000 (19:37 +0200)]
(Bug 41179) Missing content in EditPage::showDiff
Fixing another instance where the page content may be null.
Change-Id: I2f377937892dcfa5389f768edfb6033d2e6196b4
daniel [Thu, 18 Oct 2012 17:17:03 +0000 (19:17 +0200)]
(Bug 41178) Fix fatal in EditPage::displayPermissionsError.
EditPage::displayPermissionsError did not check whether getContentObject
returns false.
While we are at it, making getEditText more robust.
Change-Id: I7d6297530f57949d4a66c663490449cbdb4acad8
Marius Hoch [Thu, 18 Oct 2012 15:07:08 +0000 (17:07 +0200)]
(bug 41171) Refactor User::edits() and User::incEditCount()
User::edits() lets you fetch a cached number of edits from a slave database.
in case the field is not yet filed, we initialize if by hitting the `revision`
table and saving the result in user_editcount.
User::incEditCount() updates the edit countr and also does a lazy
initialization, if needed.
As both methods use the same $dbw->update() statement for this, I've
created a new, protected initEditCount() function which can take care of that.
Change-Id: If111270a84d4278bc4ea14d32ae602069f7c276f
Marius Hoch [Thu, 18 Oct 2012 03:03:10 +0000 (05:03 +0200)]
Unit test for User::getEditCount
Rather trivial test for User::getEditCount as suggested by
Siebrand in https://gerrit.wikimedia.org/r/26457
This required adding the User in the test to DB, as the data
is written to and read from the DB.
Change-Id: Ic4e55c01247158315b759654b34fdbdf9a61db01
Reedy [Thu, 18 Oct 2012 14:13:44 +0000 (14:13 +0000)]
Merge "(bBug 41127) Handle non-existent content in WikiPage"
daniel [Thu, 18 Oct 2012 12:44:47 +0000 (14:44 +0200)]
(bBug 41127) Handle non-existent content in WikiPage
Change-Id: I8b80a6b7b49b0b8b43eb7d4913860d8ca899015e
daniel [Thu, 18 Oct 2012 10:58:25 +0000 (12:58 +0200)]
[Bug 41128] Handle null content in action=raw.
In RawAction, there are several cases in which we have null instead
of a Content object. Most importanty, this applied for deleted revisions
and missing sections. Handle these cases gracefully.
Change-Id: Iac8560755718a46dcc4dcf118322a66d1caefdae
Siebrand [Thu, 18 Oct 2012 06:14:09 +0000 (06:14 +0000)]
Merge "Set $wgContentHandlerUseDB to false by default for now"
IAlex [Thu, 18 Oct 2012 04:38:33 +0000 (04:38 +0000)]
Merge "Fixup some method documentation return types"
Brion Vibber [Thu, 11 Oct 2012 22:37:59 +0000 (15:37 -0700)]
Work in progress on ResourceLoader mobilification
Goes along with MobileFrontend changes: https://gerrit.wikimedia.org/r/28434
Adds 'targets' option to module definitions, defaulting to 'desktop'.
Only a couple more modules are whitelisted into both desktop and mobile for now.
Startup module takes a 'target' parameter (defaults to 'desktop') to filter
the resource module registration list. Only modules matching the filter get
registered, and thus will be loadable from client-side RL.
Change-Id: Ifb772d4995b8e2ec4b63776fe0bb5b0214f82e04