This was pointed out in Ia8443e575c22f47a6d8c63038f4e7ac36815fc27. The
method checks if $url is false, but that's never the case because
getLinkPath returns string|null.
Change-Id: I7850bff928f861d796879301ba0b4e575919407e
*
* @param string|bool $pageName Page name or false (default: false)
*
*
* @param string|bool $pageName Page name or false (default: false)
*
- * @return string|bool|null
*/
public function getPageUrl( $pageName = false ) {
$url = $this->getLinkPath();
*/
public function getPageUrl( $pageName = false ) {
$url = $this->getLinkPath();
- if ( $url === false ) {
- return false;
+ if ( $url === null ) {
+ return null;
}
if ( $pageName !== false ) {
}
if ( $pageName !== false ) {
/**
* Returns the full URL for the given page on the site.
/**
* Returns the full URL for the given page on the site.
- * Or false if the needed information is not known.
+ * Or null if the needed information is not known.
*
* This generated URL is usually based upon the path returned by getLinkPath(),
* but this is not a requirement.
*
* This generated URL is usually based upon the path returned by getLinkPath(),
* but this is not a requirement.
*
* @param bool|string $pageName
*
*
* @param bool|string $pageName
*
- * @return string|bool|null
*/
public function getPageUrl( $pageName = false ) {
$url = $this->getLinkPath();
*/
public function getPageUrl( $pageName = false ) {
$url = $this->getLinkPath();
- if ( $url === false ) {
- return false;
+ if ( $url === null ) {
+ return null;
}
if ( $pageName !== false ) {
}
if ( $pageName !== false ) {