From ebeeea8748d0675c136c063a376910785191aefc Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Wed, 1 Mar 2017 14:59:30 -0800 Subject: [PATCH] Follow-up 658af7f47: Use ignoreHidden for rcenhancedfilters As we do in addModules() as well. Also move the addModuleStyles call down to addModules(). Change-Id: I537705bbf5a05ed5c1b7a0133845bcd631547f92 --- includes/specials/SpecialRecentchanges.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index a2e643bf6b..73a209bb01 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -456,8 +456,12 @@ class SpecialRecentChanges extends ChangesListSpecialPage { $panelString = implode( "\n", $panel ); // Insert a placeholder for RCFilters - if ( $this->getUser()->getOption( 'rcenhancedfilters' ) ) { - $this->getOutput()->addModuleStyles( 'mediawiki.rcfilters.filters.base.styles' ); + if ( $this->getUser()->getOption( + 'rcenhancedfilters', + /*default=*/ null, + /*ignoreHidden=*/ true + ) + ) { $this->getOutput()->addHTML( Html::element( 'div', @@ -544,6 +548,7 @@ class SpecialRecentChanges extends ChangesListSpecialPage { ) ) { $out->addModules( 'mediawiki.rcfilters.filters.ui' ); + $out->addModuleStyles( 'mediawiki.rcfilters.filters.base.styles' ); } } -- 2.20.1