From 8660cbacf2b7107fa35a71e96e7689895cd89f9f Mon Sep 17 00:00:00 2001 From: Amir Sarabadani Date: Mon, 10 Oct 2016 22:07:36 +0330 Subject: [PATCH] TemplatesOnThisPage: The second paramter in rawElement is attributes, not content With proper typehinting this wouldn't have happened Bug: T147789 Change-Id: I19ef9388acfd9159304b8141c54ce1ead27d0791 --- includes/TemplatesOnThisPageFormatter.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/TemplatesOnThisPageFormatter.php b/includes/TemplatesOnThisPageFormatter.php index c0ae374a05..494c7bfc86 100644 --- a/includes/TemplatesOnThisPageFormatter.php +++ b/includes/TemplatesOnThisPageFormatter.php @@ -93,11 +93,11 @@ class TemplatesOnThisPageFormatter { } if ( $more instanceof LinkTarget ) { - $outText .= Html::rawElement( 'li', $this->linkRenderer->makeLink( + $outText .= Html::rawElement( 'li', [], $this->linkRenderer->makeLink( $more, $this->context->msg( 'moredotdotdot' )->text() ) ); } elseif ( $more ) { // Documented as should already be escaped - $outText .= Html::rawElement( 'li', $more ); + $outText .= Html::rawElement( 'li', [], $more ); } $outText .= ''; -- 2.20.1