From 664089a3eb8d67939d3cb339f19bf42a8a71d009 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 13 Dec 2013 19:36:37 +0100 Subject: [PATCH] jpegmeta: Add links to source version and improve documentation * The closure added when this lib was imported included a jQuery reference, which is unnecessary. * Remove "Starts here" and "Ends here" comments. * Resolve the "no clue" comment. Change-Id: Ia4b66be455e28981832a4bdd8e7d3cb290d94d54 --- .../mediawiki.libs/mediawiki.libs.jpegmeta.js | 26 ++++++++++++------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/resources/mediawiki.libs/mediawiki.libs.jpegmeta.js b/resources/mediawiki.libs/mediawiki.libs.jpegmeta.js index 224292464e..b3ed88c8fd 100644 --- a/resources/mediawiki.libs/mediawiki.libs.jpegmeta.js +++ b/resources/mediawiki.libs/mediawiki.libs.jpegmeta.js @@ -1,10 +1,16 @@ -/* This is JsJpegMeta 1.0, ported to MediaWiki ResourceLoader by Bryan Tong Minh */ -/* The following lines where changed with respect to the original: 54, 625-627 */ +/** + * This is JsJpegMeta v1.0 + * From: https://code.google.com/p/jsjpegmeta/downloads/list + * From: https://github.com/bennoleslie/jsjpegmeta/blob/v1.0.0/jpegmeta.js + * + * Ported to MediaWiki ResourceLoader by Bryan Tong Minh + * Changes: + * - Add closure. + * - Add this.JpegMeta assignment to expose it as global. + * - Add mw.libs.jpegmeta wrapper. + */ -(function( $ ) { - - /* JsJpegMeta starts here */ - +( function () { /* Copyright (c) 2009 Ben Leslie @@ -52,7 +58,8 @@ */ var JpegMeta = {}; - this.JpegMeta = JpegMeta; // I have no clue why I need this magic... -- Bryan + // MediaWiki: Expose as global + this.JpegMeta = JpegMeta; /* parse an unsigned number of size bytes at offset in some binary string data. @@ -721,11 +728,10 @@ } } }; - - /* JsJpegMeta ends here */ + // MediaWiki: Add mw.libs wrapper mw.libs.jpegmeta = function( fileReaderResult, fileName ) { return new JpegMeta.JpegFile( fileReaderResult, fileName ); }; -} )( jQuery ); +}() ); -- 2.20.1