From 54a48ef1b296dca9b1810fda53b33556b1ccd5f2 Mon Sep 17 00:00:00 2001 From: Rohan Date: Wed, 25 Jun 2014 22:09:04 +0530 Subject: [PATCH] Disables upload by url option for users without the necessary permissions Does an explicit check for a true value in SpecialUpload::getSourceSection Bug: 39507 Change-Id: I00297494230d07081dd85a810321446badc3ecb0 --- includes/specials/SpecialUpload.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/specials/SpecialUpload.php b/includes/specials/SpecialUpload.php index 01c0aaf6f6..976294bb1a 100644 --- a/includes/specials/SpecialUpload.php +++ b/includes/specials/SpecialUpload.php @@ -827,7 +827,7 @@ class UploadForm extends HTMLForm { } $canUploadByUrl = UploadFromUrl::isEnabled() - && UploadFromUrl::isAllowed( $this->getUser() ) + && ( UploadFromUrl::isAllowed( $this->getUser() ) === true ) && $wgCopyUploadsFromSpecialUpload; $radio = $canUploadByUrl; $selectedSourceType = strtolower( $this->getRequest()->getText( 'wpSourceType', 'File' ) ); -- 2.20.1