From 482c3a657c3ab757969b9ad61699b330591396cd Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Sat, 30 Mar 2019 02:57:57 +0000 Subject: [PATCH] resourceloader: Remove deprecated MessageBlobStore::getBlob This class is basically `@internal`, but not yet marked as such. The only non-core use case is a WikimediaMaintenance script, so I suppose we can keep it public. It's purpose is for batching, the single blob method is not used anywhere in Wikimedia Git. Change-Id: If2a0497b1412efbfd55b34b512d2b9e5346359fb --- RELEASE-NOTES-1.33 | 2 ++ includes/resourceloader/MessageBlobStore.php | 8 -------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33 index 6e5de2c76f..2b514af713 100644 --- a/RELEASE-NOTES-1.33 +++ b/RELEASE-NOTES-1.33 @@ -346,6 +346,8 @@ because of Phabricator reports. to "Pàgina printzipale". Existing wikis using this content language need to move the main page or change the name through MediaWiki:Mainpage page. * wfSplitWikiID(), deprecated in 1.32, has been removed. +* MessageBlobStore::getBlob(), deprecated in 1.27, has been removed. + Use ::getBlobs() instead. === Deprecations in 1.33 === * The configuration option $wgUseESI has been deprecated, and is expected diff --git a/includes/resourceloader/MessageBlobStore.php b/includes/resourceloader/MessageBlobStore.php index ceb51f2d3f..b7c19042ca 100644 --- a/includes/resourceloader/MessageBlobStore.php +++ b/includes/resourceloader/MessageBlobStore.php @@ -121,14 +121,6 @@ class MessageBlobStore implements LoggerAwareInterface { return $blobs; } - /** - * @deprecated since 1.27 Use getBlobs() instead - * @return array - */ - public function get( ResourceLoader $resourceLoader, $modules, $lang ) { - return $this->getBlobs( $modules, $lang ); - } - /** * @since 1.27 * @param ResourceLoaderModule $module -- 2.20.1