From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 9 Oct 2013 19:08:14 +0000 (+0200)
Subject: deleteEqualMessages: Exclude messages that are empty by default
X-Git-Tag: 1.31.0-rc.0~18467^2
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dmembres/cotisations/gestion/rappel_supprimer.php?a=commitdiff_plain;h=dafd0ce5aa0dba58a403330646202cfcbd3d4b48;p=lhc%2Fweb%2Fwiklou.git

deleteEqualMessages: Exclude messages that are empty by default

The main purpose of this script is to purge local overrides to
avoid them from blocking an i18n update in the future.

However empty messages should remain empty and often have a
richer edit history (e.g. Sitenotice) and may not stay empty
for long.

Change-Id: I5b416cda25a3641862df9919c46ae59ad5d5d6e0
---

diff --git a/maintenance/deleteEqualMessages.php b/maintenance/deleteEqualMessages.php
index 1e36363919..81758913dd 100644
--- a/maintenance/deleteEqualMessages.php
+++ b/maintenance/deleteEqualMessages.php
@@ -70,7 +70,13 @@ class DeleteEqualMessages extends Maintenance {
 				$default = wfMessage( $key )->inLanguage( $langCode )->useDatabase( false )->plain();
 
 				$messageInfo['relevantPages']++;
-				if ( $actual === $default ) {
+
+				if (
+					// Exclude messages that are empty by default, such as sitenotice, specialpage
+					// summaries and accesskeys.
+					$default !== '' && $default !== '-' &&
+						$actual === $default
+				) {
 					$hasTalk = isset( $statuses['talks'][$key] );
 					$messageInfo['results'][] = array(
 						'title' => $key . $titleSuffix,