From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Sun, 21 Sep 2008 22:56:59 +0000 (+0000)
Subject: rc_log_type can be null, and NULL != 'x' is treated as false, which borked the count... 
X-Git-Tag: 1.31.0-rc.0~45151
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dmembres/cotisations/gestion/rappel_supprimer.php?a=commitdiff_plain;h=41591cbdce686138efe0831de215170c8802787a;p=lhc%2Fweb%2Fwiklou.git

rc_log_type can be null, and NULL != 'x' is treated as false, which borked the count. (bug 15682)
---

diff --git a/includes/SiteStats.php b/includes/SiteStats.php
index 3729f455a7..2bca25fa20 100644
--- a/includes/SiteStats.php
+++ b/includes/SiteStats.php
@@ -258,7 +258,7 @@ class SiteStatsUpdate {
 		# Get non-bot users than did some recent action other than making accounts.
 		# If account creation is included, the number gets inflated ~20+ fold on enwiki.
 		$activeUsers = $dbr->selectField( 'recentchanges', 'COUNT( DISTINCT rc_user_text )',
-			array( 'rc_user != 0', 'rc_bot' => 0, "rc_log_type != 'newusers'" ),
+			array( 'rc_user != 0', 'rc_bot' => 0, "rc_log_type != 'newusers' OR rc_log_type IS NULL" ),
 			__METHOD__ );
 		$dbw->update( 'site_stats', 
 			array( 'ss_active_users' => intval($activeUsers) ),