mwjsduck-gen: Don't fail when running from different directory
authorBartosz Dziewoński <matma.rex@gmail.com>
Mon, 14 Apr 2014 19:03:46 +0000 (21:03 +0200)
committerBartosz Dziewoński <matma.rex@gmail.com>
Fri, 18 Apr 2014 09:09:14 +0000 (11:09 +0200)
* Do not directly use $0 in help output, use basename instead
* Do not use paths relative to the currect directory

(Full disclosure: I can't write bash.)

Change-Id: I4c73155cd691a2ddf134724e9df94e6594b78a02

maintenance/mwjsduck-gen

index 62d1bba..442163e 100755 (executable)
@@ -6,21 +6,22 @@ then
        JSDUCK_MWVERSION="$2"
 elif [[ "$*" != "" ]]
 then
-       echo "Usage: $0 [--version <mediawiki version>]"
+       FILENAME=$(basename $0)
+       echo "Usage: $FILENAME [--version <mediawiki version>]"
        echo
        exit 1
 fi
 
+MWCORE_DIR=$(cd $(dirname $0)/..; pwd)
+
 # Support jsduck 4.x and 5.x
 JSDUCK_VERSION="$(jsduck --version | sed -e 's/[.].*//')"
 if [  "$JSDUCK_VERSION" = "JSDuck 4" ]; then
-       JSDUCK_VERSION_OPT="--meta-tags ./maintenance/jsduck/MetaTags.rb --warnings=-no_doc"
+       JSDUCK_VERSION_OPT="--meta-tags $MWCORE_DIR/maintenance/jsduck/MetaTags.rb --warnings=-no_doc"
 else
-       JSDUCK_VERSION_OPT="--tags ./maintenance/jsduck/CustomTags.rb --warnings=-nodoc(class,public)"
+       JSDUCK_VERSION_OPT="--tags $MWCORE_DIR/maintenance/jsduck/CustomTags.rb --warnings=-nodoc(class,public)"
 fi
 
-MWCORE_DIR=$(cd $(dirname $0)/..; pwd)
-
 jsduck \
 --config=$MWCORE_DIR/maintenance/jsduck/config.json \
 $JSDUCK_VERSION_OPT \