Merge "Add tests for SkinTemplate::setupSkinUserCss"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Sat, 28 Jan 2017 17:25:41 +0000 (17:25 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sat, 28 Jan 2017 17:25:41 +0000 (17:25 +0000)
1  2 
includes/skins/SkinTemplate.php

@@@ -61,7 -61,7 +61,7 @@@ class SkinTemplate extends Skin 
         *
         * @param OutputPage $out
         */
-       function setupSkinUserCss( OutputPage $out ) {
+       public function setupSkinUserCss( OutputPage $out ) {
                $moduleStyles = [
                        'mediawiki.legacy.shared',
                        'mediawiki.legacy.commonPrint',
                                'href' => $this->getTitle()->getLocalURL( "action=info" )
                        ];
  
 -                      if ( $this->getTitle()->exists() ) {
 +                      if ( $this->getTitle()->exists() || $this->getTitle()->inNamespace( NS_CATEGORY ) ) {
                                $nav_urls['recentchangeslinked'] = [
                                        'href' => SpecialPage::getTitleFor( 'Recentchangeslinked', $this->thispage )->getLocalURL()
                                ];
                        if ( !$user->isAnon() ) {
                                $sur = new UserrightsPage;
                                $sur->setContext( $this->getContext() );
 -                              $canChange = $sur->userCanChangeRights( $this->getUser(), false );
 +                              $canChange = $sur->userCanChangeRights( $user );
                                $nav_urls['userrights'] = [
                                        'text' => $this->msg(
                                                $canChange ? 'tool-link-userrights' : 'tool-link-userrights-readonly',
 -                                              $this->getUser()->getName()
 +                                              $rootUser
                                        )->text(),
                                        'href' => self::makeSpecialUrlSubpage( 'Userrights', $rootUser )
                                ];