From e1a4376a191deb9a1b9bb03cc85598f565e5c06f Mon Sep 17 00:00:00 2001
From: Rob Church <robchurch@users.mediawiki.org>
Date: Fri, 6 Jul 2007 22:58:29 +0000
Subject: [PATCH] * Code conventions - spacing, minor refactoring * Correct
 errant release note

---
 RELEASE-NOTES            |  3 +--
 includes/PageHistory.php | 11 ++++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 399355e8da..9e80ceae06 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -122,8 +122,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 10438) HTML TeX formulas should not wrap
 * Introduce "raw editing" mode for the watchlist, to allow bulk additions,
   removals, and convenient exporting of watchlist contents
-* Put an (undo) button on the page history page, for people with rollback
-  permission only
+* Show "undo" links in page histories
 * Option to jump to specified time period in user contributions
 
 == Bugfixes since 1.10 ==
diff --git a/includes/PageHistory.php b/includes/PageHistory.php
index a89b75ba75..2b57d66593 100644
--- a/includes/PageHistory.php
+++ b/includes/PageHistory.php
@@ -248,12 +248,13 @@ class PageHistory {
 			$s .= ' '.$this->mSkin->generateRollback( $rev );
 		}
 
-		if ( !is_null($next)) {
+		if ( !is_null( $next ) ) {
 			$undolink = $this->mSkin->makeKnownLinkObj(
-				$this->mTitle, '('.htmlspecialchars( wfMsg( 'editundo' ) ).')',
-				'action=edit&undoafter=' . $next->rev_id . '&undo=' . $rev->getId(),
-				'', '', '', null );
-			$s .= ' <span class="mw-history-undo"> '."$undolink </span>";
+				$this->mTitle,
+				'(' . wfMsgHtml( 'editundo' ) . ')',
+				'action=edit&undoafter=' . $next->rev_id . '&undo=' . $rev->getId()
+			);
+			$s .= " <span class=\"mw-history-undo\">{$undolink}</span>";
 		}
 		
 		wfRunHooks( 'PageHistoryLineEnding', array( &$row , &$s ) );
-- 
2.20.1