From cad1b31a2a12cddb65ec11a531e94a87976939aa Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Sun, 7 Apr 2019 20:44:46 -0700 Subject: [PATCH] Use IMaintainableDatabase type hint for DatabaseUpdater::newForDB() Change-Id: I56dd9f8d195ad60cf3ec9b81af2b4f25d1ca0a3a --- includes/installer/DatabaseUpdater.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/includes/installer/DatabaseUpdater.php b/includes/installer/DatabaseUpdater.php index 750f10870a..5add0a837e 100644 --- a/includes/installer/DatabaseUpdater.php +++ b/includes/installer/DatabaseUpdater.php @@ -22,6 +22,7 @@ */ use Wikimedia\Rdbms\Database; use Wikimedia\Rdbms\IDatabase; +use Wikimedia\Rdbms\IMaintainableDatabase; use MediaWiki\MediaWikiServices; require_once __DIR__ . '/../../maintenance/Maintenance.php'; @@ -177,14 +178,18 @@ abstract class DatabaseUpdater { } /** - * @param Database $db + * @param IMaintainableDatabase $db * @param bool $shared * @param Maintenance|null $maintenance * * @throws MWException * @return DatabaseUpdater */ - public static function newForDB( Database $db, $shared = false, Maintenance $maintenance = null ) { + public static function newForDB( + IMaintainableDatabase $db, + $shared = false, + Maintenance $maintenance = null + ) { $type = $db->getType(); if ( in_array( $type, Installer::getDBTypes() ) ) { $class = ucfirst( $type ) . 'Updater'; -- 2.20.1