From b6a567cf491c10b338bcda9eaa5bac92ca37e491 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gerg=C5=91=20Tisza?= Date: Fri, 16 Nov 2018 14:40:28 -0800 Subject: [PATCH] config: Change ConfigException to extend LogicException This exception is thrown when someone tries to fetch a configuration entry with an invalid name, or override an already set entry, both of which are errors in the logic and cannot be meaningfully handled, so it does not make sense for this exception to trigger IDE warnings. (The one exception is the etcd load error, which probably shouldn't be a ConfigException in the first place. But even that is not something callers could meaningfully handle.) Change-Id: I26b5b32f3348965f0cbf607cbb7cb5aaa509ed51 --- includes/config/ConfigException.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/config/ConfigException.php b/includes/config/ConfigException.php index 3b3ba9de37..b2d0fc6eb2 100644 --- a/includes/config/ConfigException.php +++ b/includes/config/ConfigException.php @@ -25,5 +25,5 @@ * * @since 1.23 */ -class ConfigException extends Exception { +class ConfigException extends LogicException { } -- 2.20.1