From 5fd0427041b7013b46dd96c4a7659f677458b4fa Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Wed, 10 Dec 2008 23:29:43 +0000 Subject: [PATCH] Revert r44292 "Assign by ref to make sure cache fields carry over" This isn't PHP 4; the object's fields are changed on the object itself just fine. Unless people are changing the global variable $wgTitle to something different this should be fine. If there is a problem that this fixes, that's probably a problem itself and should be fixed in a cleaner way :D --- includes/Skin.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/Skin.php b/includes/Skin.php index d02c0770fb..03d6dd2764 100644 --- a/includes/Skin.php +++ b/includes/Skin.php @@ -266,7 +266,7 @@ class Skin extends Linker { function setMembers(){ global $wgTitle, $wgUser; - $this->mTitle =& $wgTitle; + $this->mTitle = $wgTitle; $this->mUser = $wgUser; $this->userpage = $wgUser->getUserPage()->getPrefixedText(); $this->usercss = false; -- 2.20.1