From 5f7bf1942b1e4577bf54a040468b65eb1d255ed6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Mon, 23 Jul 2018 18:18:04 +0200 Subject: [PATCH] LogEventsList: Correct typo The parameter to getTitleInputDesc() is actually unused, so this was not breaking anything. Change-Id: Ia301faf511e30b4fc4542ccb80b24cf807cf731c --- includes/logging/LogEventsList.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/includes/logging/LogEventsList.php b/includes/logging/LogEventsList.php index c9a7299862..d2218e537f 100644 --- a/includes/logging/LogEventsList.php +++ b/includes/logging/LogEventsList.php @@ -110,8 +110,6 @@ class LogEventsList extends ContextSource { public function showOptions( $types = [], $user = '', $page = '', $pattern = false, $year = 0, $month = 0, $day = 0, $filter = null, $tagFilter = '', $action = null ) { - $title = SpecialPage::getTitleFor( 'Log' ); - // For B/C, we take strings, but make sure they are converted... $types = ( $types === '' ) ? [] : (array)$types; @@ -120,7 +118,7 @@ class LogEventsList extends ContextSource { // Basic selectors $formDescriptor['type'] = $this->getTypeMenuDesc( $types ); $formDescriptor['user'] = $this->getUserInputDesc( $user ); - $formDescriptor['page'] = $this->getTitleInputDesc( $title ); + $formDescriptor['page'] = $this->getTitleInputDesc( $page ); // Add extra inputs if any // This could either be a form descriptor array or a string with raw HTML. @@ -171,7 +169,7 @@ class LogEventsList extends ContextSource { } $context = new DerivativeContext( $this->getContext() ); - $context->setTitle( $title ); // Remove subpage + $context->setTitle( SpecialPage::getTitleFor( 'Log' ) ); // Remove subpage $htmlForm = new HTMLForm( $formDescriptor, $context ); $htmlForm ->setSubmitText( $this->msg( 'logeventslist-submit' )->text() ) -- 2.20.1