From 39e6a7f0c021cdee95939ffa9a176e5e806675b0 Mon Sep 17 00:00:00 2001 From: Ivan Lanin Date: Wed, 10 Jan 2007 19:13:27 +0000 Subject: [PATCH] Fix SpecialVersion->formatCredits input. Version and Url parameters should be null to be treated properly with isset. --- RELEASE-NOTES | 2 ++ includes/SpecialVersion.php | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index b376941cd4..456253f8d7 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -37,6 +37,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * (bugs 5051, 5376) Tooltips and accesskeys no longer require JavaScript * Added SkinTemplateOutputPageBeforeExec hook before SkinTemplate::outputPage() starts page output (http://lists.wikimedia.org/pipermail/wikitech-l/2007-January/028554.html) +* Fix SpecialVersion->formatCredits input. Version and Url parameters should be null + to be treated properly with isset. == Languages updated == diff --git a/includes/SpecialVersion.php b/includes/SpecialVersion.php index 36da5caf40..cdd31f5ef2 100644 --- a/includes/SpecialVersion.php +++ b/includes/SpecialVersion.php @@ -118,9 +118,9 @@ class SpecialVersion { foreach ( $wgExtensionCredits[$type] as $extension ) { $out .= $this->formatCredits( isset ( $extension['name'] ) ? $extension['name'] : '', - isset ( $extension['version'] ) ? $extension['version'] : '', + isset ( $extension['version'] ) ? $extension['version'] : null, isset ( $extension['author'] ) ? $extension['author'] : '', - isset ( $extension['url'] ) ? $extension['url'] : '', + isset ( $extension['url'] ) ? $extension['url'] : null, isset ( $extension['description'] ) ? $extension['description'] : '' ); } @@ -193,7 +193,7 @@ class SpecialVersion { foreach ($myWgHooks as $hook => $hooks) $ret .= "$hook" . $this->listToText( $hooks ) . "\n"; - + $ret .= ''; return $ret; } else -- 2.20.1