From: Kevin Israel <pleasestand@live.com>
Date: Fri, 30 Oct 2015 09:29:12 +0000 (-0400)
Subject: Update description of LinkCache::forUpdate()
X-Git-Tag: 1.31.0-rc.0~9166
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dcompta/comptes/journal.php?a=commitdiff_plain;h=eb8d6eb754cc00e44ee27914639db762c0f3b6f6;p=lhc%2Fweb%2Fwiklou.git

Update description of LinkCache::forUpdate()

The $mForUpdate flag no longer causes the FOR UPDATE option to be added.
This was at first only true for some values of $wgAntiLockFlags (since
r9248 / ba8a00bcb833), though since 12757b50f8da (when the setting was
removed), is always the case.

The added text is based on the description for $wgAntiLockFlags.

Change-Id: I02a3e2df37ec40c7e36ae6210c8263f13d9e3e5b
---

diff --git a/includes/cache/LinkCache.php b/includes/cache/LinkCache.php
index 3db84a6e75..4c456869f5 100644
--- a/includes/cache/LinkCache.php
+++ b/includes/cache/LinkCache.php
@@ -88,7 +88,11 @@ class LinkCache {
 	}
 
 	/**
-	 * General accessor to get/set whether SELECT FOR UPDATE should be used
+	 * General accessor to get/set whether the master DB should be used
+	 *
+	 * This used to also set the FOR UPDATE option (locking the rows read
+	 * in order to avoid link table inconsistency), which was later removed
+	 * for performance on wikis with a high edit rate.
 	 *
 	 * @param bool $update
 	 * @return bool