From: Juan Osorio <osorio.juan@microsoft.com>
Date: Fri, 5 Apr 2019 21:47:38 +0000 (-0700)
Subject: Fixes LocalFile isMissing always returning true
X-Git-Tag: 1.34.0-rc.0~2139^2
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dcompta/comptes/journal.php?a=commitdiff_plain;h=bf29eadf3ea4bcaff236c15b3ee7315cdf186da2;p=lhc%2Fweb%2Fwiklou.git

Fixes LocalFile isMissing always returning true

Bug: T220244
Change-Id: I6f4e1371759559a14cb7b2125792fcfbba7e4cf3
---

diff --git a/includes/filerepo/file/LocalFile.php b/includes/filerepo/file/LocalFile.php
index 134a1045c1..aa04faec8f 100644
--- a/includes/filerepo/file/LocalFile.php
+++ b/includes/filerepo/file/LocalFile.php
@@ -796,11 +796,14 @@ class LocalFile extends File {
 	/** isVisible inherited */
 
 	/**
+	 * Checks if this file exists in its parent repo, as referenced by its
+	 * virtual URL.
+	 *
 	 * @return bool
 	 */
 	function isMissing() {
 		if ( $this->missing === null ) {
-			list( $fileExists ) = $this->repo->fileExists( $this->getVirtualUrl() );
+			$fileExists = $this->repo->fileExists( $this->getVirtualUrl() );
 			$this->missing = !$fileExists;
 		}