From: Ori Livneh <ori@wikimedia.org>
Date: Fri, 11 Jul 2014 20:49:00 +0000 (-0700)
Subject: Remove ResourceLoaderGetStartupModules hook
X-Git-Tag: 1.31.0-rc.0~14985^2
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dcompta/comptes/journal.php?a=commitdiff_plain;h=7fb6675a8f8f98f836cd44f827b7c94393e16afc;p=lhc%2Fweb%2Fwiklou.git

Remove ResourceLoaderGetStartupModules hook

Deprecated only since 1.23, but universally reviled, and used only by
MwEmbedSupport, which no longer uses it as of I43af3c87a).

Change-Id: I36c89b273fdb0ec3a76034c7a6d2f48a15d5457f
---

diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24
index 50ee9494e0..82ec1dc1ed 100644
--- a/RELEASE-NOTES-1.24
+++ b/RELEASE-NOTES-1.24
@@ -240,6 +240,7 @@ changes to languages because of Bugzilla reports.
 * Removed MWInit class which contained functions related to a now discontinued
   PHP compiler called hphpc. (deprecated since 1.22)
 * ApiResult::enableSizeCheck() and disableSizeCheck() are now obsolete.
+* Removed ResourceLoaderGetStartupModules hook. (deprecated since 1.23)
 
 ==== Renamed classes ====
 * CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression
diff --git a/docs/hooks.txt b/docs/hooks.txt
index e4474c53cc..0bbcd0ea99 100644
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -2158,12 +2158,6 @@ configuration variables to JavaScript. Things that depend on the current page
 or request state must be added through MakeGlobalVariablesScript instead.
 &$vars: array( variable name => value )
 
-'ResourceLoaderGetStartupModules': DEPRECATED. Run once the startup module is being
-generated. This allows you to add modules to the startup module. This hook
-should be used sparingly since any module added here will be loaded on all
-pages. This hook is useful if you want to make code available to module loader
-scripts.
-
 'ResourceLoaderRegisterModules': Right before modules information is required,
 such as when responding to a resource
 loader request or generating HTML output.
diff --git a/includes/resourceloader/ResourceLoaderStartUpModule.php b/includes/resourceloader/ResourceLoaderStartUpModule.php
index 8a936c6ca6..56eb0a0008 100644
--- a/includes/resourceloader/ResourceLoaderStartUpModule.php
+++ b/includes/resourceloader/ResourceLoaderStartUpModule.php
@@ -345,7 +345,6 @@ class ResourceLoaderStartUpModule extends ResourceLoaderModule {
 	public static function getStartupModulesUrl( ResourceLoaderContext $context ) {
 		// The core modules:
 		$moduleNames = array( 'jquery', 'mediawiki' );
-		wfRunHooks( 'ResourceLoaderGetStartupModules', array( &$moduleNames ), '1.23' );
 
 		// Get the latest version
 		$loader = $context->getResourceLoader();