From: Timo Tijhof <krinklemail@gmail.com>
Date: Sat, 9 Mar 2019 05:06:36 +0000 (+0000)
Subject: resourceloader: Remove redundant var-freeing in addScript()
X-Git-Tag: 1.34.0-rc.0~2542^2
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dcompta/comptes/journal.php?a=commitdiff_plain;h=7706ef1e67933bc85f2202c175d3652e379cb491;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Remove redundant var-freeing in addScript()

This was copied from jQuery 1.x, where it existed to reduce
memory usage in IE6-8. This was because it's JS engine was not
able to break the circular closure reference (the function
invocation has a reference to the script element, the script
element has an event listener with closure access to the script
element). This bug is no longer relevant.

Change-Id: I6fd66c5fbf3afb3c9e09bba6322dc3fac2fad4a6
---

diff --git a/resources/src/startup/mediawiki.js b/resources/src/startup/mediawiki.js
index a0c7c61983..5c574a2efa 100644
--- a/resources/src/startup/mediawiki.js
+++ b/resources/src/startup/mediawiki.js
@@ -1120,7 +1120,6 @@
 					if ( script.parentNode ) {
 						script.parentNode.removeChild( script );
 					}
-					script = null;
 					if ( callback ) {
 						callback();
 						callback = null;