From: Chad Horohoe <demon@users.mediawiki.org>
Date: Sat, 23 Oct 2010 15:16:25 +0000 (+0000)
Subject: Fix a few visibilities, add a @todo
X-Git-Tag: 1.31.0-rc.0~34370
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dcompta/comptes/journal.php?a=commitdiff_plain;h=6afcf0f20c60d331114b4e6c4762969961fecc48;p=lhc%2Fweb%2Fwiklou.git

Fix a few visibilities, add a @todo
---

diff --git a/includes/installer/CoreInstaller.php b/includes/installer/CoreInstaller.php
index f0422eb0b9..60d5acc691 100644
--- a/includes/installer/CoreInstaller.php
+++ b/includes/installer/CoreInstaller.php
@@ -232,6 +232,8 @@ abstract class CoreInstaller extends Installer {
 	/**
 	 * Register tag hook below.
 	 *
+	 * @todo Move this to WebInstaller with the two things below?
+	 *
 	 * @param $parser Parser
 	 */
 	public function registerDocLink( Parser &$parser ) {
@@ -288,7 +290,7 @@ abstract class CoreInstaller extends Installer {
 	 *
 	 * @return Status
 	 */
-	public function installExtensions() {
+	protected function installExtensions() {
 		$exts = $this->getVar( '_Extensions' );
 		$path = $this->getVar( 'IP' ) . '/extensions';
 
@@ -305,7 +307,7 @@ abstract class CoreInstaller extends Installer {
 	 *
 	 * @return array
 	 */
-	public function getInstallSteps() {
+	protected function getInstallSteps() {
 		if( $this->getVar( '_UpgradeDone' ) ) {
 			$this->installSteps = array( 'localsettings' );
 		}
@@ -369,7 +371,7 @@ abstract class CoreInstaller extends Installer {
 	 *
 	 * @return Status
 	 */
-	public function installSecretKey() {
+	protected function installSecretKey() {
 		if ( wfIsWindows() ) {
 			$file = null;
 		} else {
@@ -403,7 +405,7 @@ abstract class CoreInstaller extends Installer {
 	 *
 	 * @return Status
 	 */
-	public function installSysop() {
+	protected function installSysop() {
 		$name = $this->getVar( '_AdminName' );
 		$user = User::newFromName( $name );