From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 15 Feb 2018 10:30:12 +0000 (-0800)
Subject: rdbms: remove leading table name space hack in Database
X-Git-Tag: 1.31.0-rc.0~593^2
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dcompta/comptes/journal.php?a=commitdiff_plain;h=4c90502371cb8d5c6ab1e41f3478ed14ec662834;p=lhc%2Fweb%2Fwiklou.git

rdbms: remove leading table name space hack in Database

This was added in r19879 (3de6fd8c8) with no provided use case.
There also appears to be nothing exploiting this.

Change-Id: I1641d4ed16d612ab6f08ee1eeca1580af73888bf
---

diff --git a/includes/libs/rdbms/database/Database.php b/includes/libs/rdbms/database/Database.php
index d1814e18b5..b24b8cbba8 100644
--- a/includes/libs/rdbms/database/Database.php
+++ b/includes/libs/rdbms/database/Database.php
@@ -1405,13 +1405,9 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware
 				$this->tableNamesWithIndexClauseOrJOIN(
 					$table, $useIndexes, $ignoreIndexes, $join_conds );
 		} elseif ( $table != '' ) {
-			if ( $table[0] == ' ' ) {
-				$from = ' FROM ' . $table;
-			} else {
-				$from = ' FROM ' .
-					$this->tableNamesWithIndexClauseOrJOIN(
-						[ $table ], $useIndexes, $ignoreIndexes, [] );
-			}
+			$from = ' FROM ' .
+				$this->tableNamesWithIndexClauseOrJOIN(
+					[ $table ], $useIndexes, $ignoreIndexes, [] );
 		} else {
 			$from = '';
 		}