From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Tue, 19 Feb 2019 17:25:14 +0000 (+0100)
Subject: Fix HeaderCallback failing on headers without a colon
X-Git-Tag: 1.34.0-rc.0~2632^2
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dcompta/comptes/journal.php?a=commitdiff_plain;h=1aaa08bf370273bc354f08f624f2550c526d9703;p=lhc%2Fweb%2Fwiklou.git

Fix HeaderCallback failing on headers without a colon

Bug: T216086
Change-Id: I3007a5bc238a5271cc3fe4da1844ff74efd58be0
---

diff --git a/includes/HeaderCallback.php b/includes/HeaderCallback.php
index b2ca6733f6..650a3a8463 100644
--- a/includes/HeaderCallback.php
+++ b/includes/HeaderCallback.php
@@ -22,8 +22,12 @@ class HeaderCallback {
 		// Prevent caching of responses with cookies (T127993)
 		$headers = [];
 		foreach ( headers_list() as $header ) {
-			list( $name, $value ) = explode( ':', $header, 2 );
-			$headers[strtolower( trim( $name ) )][] = trim( $value );
+			$header = explode( ':', $header, 2 );
+
+			// Note: The code below (currently) does not care about value-less headers
+			if ( isset( $header[1] ) ) {
+				$headers[ strtolower( trim( $header[0] ) ) ][] = trim( $header[1] );
+			}
 		}
 
 		if ( isset( $headers['set-cookie'] ) ) {