Merge "[search] Don't show the create link twice on results page"

diff --combined includes/specials/SpecialSearch.php
index e7a8677,ef514c7..9280b04
--- 1/includes/specials/SpecialSearch.php
--- 2/includes/specials/SpecialSearch.php
+++ b/includes/specials/SpecialSearch.php
@@@ -234,6 -234,11 +234,6 @@@ class SpecialSearch extends SpecialPag
  
                        return;
                }
 -              # No match, generate an edit URL
 -              $title = Title::newFromText( $term );
 -              if ( !is_null( $title ) ) {
 -                      Hooks::run( 'SpecialSearchNogomatch', [ &$title ] );
 -              }
                $this->showResults( $term );
        }
  
@@@ -417,7 -422,12 +417,12 @@@
                                $out->addHTML( '<div class="error">' .
                                        $textStatus->getMessage( 'search-error' ) . '</div>' );
                        } else {
-                               $this->showCreateLink( $title, $num, $titleMatches, $textMatches );
+                               if ( !$this->offset ) {
+                                       // If we have an offset the create link was rendered earlier in this function.
+                                       // This class needs a good de-spaghettification, but for now this will
+                                       // do the job.
+                                       $this->showCreateLink( $title, $num, $titleMatches, $textMatches );
+                               }
                                $out->wrapWikiMsg( "<p class=\"mw-search-nonefound\">\n$1</p>",
                                        [ $hasOtherResults ? 'search-nonefound-thiswiki' : 'search-nonefound',
                                                        wfEscapeWikiText( $term )
@@@ -450,6 -460,7 +455,6 @@@
                $out->addHTML( "</div>" );
  
                Hooks::run( 'SpecialSearchResultsAppend', [ $this, $out, $term ] );
 -
        }
  
        /**
@@@ -464,6 -475,25 +469,6 @@@
                return "<p class=\"mw-search-interwiki-header mw-search-visualclear\">\n$wikiMsg</p>";
        }
  
 -      /**
 -       * Decide if the suggested query should be run, and it's results returned
 -       * instead of the provided $textMatches
 -       *
 -       * @param SearchResultSet $textMatches The results of a users query
 -       * @return bool
 -       */
 -      protected function shouldRunSuggestedQuery( SearchResultSet $textMatches ) {
 -              if ( !$this->runSuggestion ||
 -                      !$textMatches->hasSuggestion() ||
 -                      $textMatches->numRows() > 0 ||
 -                      $textMatches->searchContainedSyntax()
 -              ) {
 -                      return false;
 -              }
 -
 -              return $this->getConfig()->get( 'SearchRunSuggestedQuery' );
 -      }
 -
        /**
         * Generates HTML shown to the user when we have a suggestion about a query
         * that might give more results than their current query.
@@@ -727,6 -757,7 +732,6 @@@
         * @return string
         */
        protected function showHit( SearchResult $result, $terms, $position ) {
 -
                if ( $result->isBrokenTitle() ) {
                        return '';
                }
@@@ -946,6 -977,7 +951,6 @@@
         * @return string
         */
        protected function showInterwikiHit( $result, $lastInterwiki, $query ) {
 -
                if ( $result->isBrokenTitle() ) {
                        return '';
                }
@@@ -1308,6 -1340,24 +1313,6 @@@
                return false;
        }
  
 -      /**
 -       * Check if query starts with all: prefix
 -       *
 -       * @param string $term The string to check
 -       * @return bool
 -       */
 -      protected function startsWithAll( $term ) {
 -
 -              $allkeyword = $this->msg( 'searchall' )->inContentLanguage()->text();
 -
 -              $parts = explode( ':', $term );
 -              if ( count( $parts ) > 1 ) {
 -                      return $parts[0] == $allkeyword;
 -              }
 -
 -              return false;
 -      }
 -
        /**
         * @since 1.18
         *