Merge "Consistently use spaces and stars in comments"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 30 May 2019 22:11:49 +0000 (22:11 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 30 May 2019 22:11:49 +0000 (22:11 +0000)
1  2 
tests/phpunit/includes/api/ApiEditPageTest.php

@@@ -39,6 -39,7 +39,6 @@@ class ApiEditPageTest extends ApiTestCa
                        $this->tablesUsed,
                        [ 'change_tag', 'change_tag_def', 'logging' ]
                );
 -              $this->overrideMwServices();
        }
  
        public function testEdit() {
                $count++;
  
                /*
-               * T43990: if the target page has a newer revision than the redirect, then editing the
-               * redirect while specifying 'redirect' and *not* specifying 'basetimestamp' erroneously
-               * caused an edit conflict to be detected.
-               */
+                * T43990: if the target page has a newer revision than the redirect, then editing the
+                * redirect while specifying 'redirect' and *not* specifying 'basetimestamp' erroneously
+                * caused an edit conflict to be detected.
+                */
  
                // assume NS_HELP defaults to wikitext
                $name = "Help:ApiEditPageTest_testEditConflict_redirect_T43990_$count";
                ChangeTags::defineTag( 'custom tag' );
                $this->setMwGlobals( 'wgRevokePermissions',
                        [ 'user' => [ 'applychangetags' => true ] ] );
 -              // Supply services with updated globals
 -              $this->overrideMwServices();
 -
                try {
                        $this->doApiRequestWithToken( [
                                'action' => 'edit',
  
                $this->setMwGlobals( 'wgRevokePermissions',
                        [ 'user' => [ 'upload' => true ] ] );
 -              // Supply services with updated globals
 -              $this->overrideMwServices();
  
                $this->doApiRequestWithToken( [
                        'action' => 'edit',
                        'The content you supplied exceeds the article size limit of 1 kilobyte.' );
  
                $this->setMwGlobals( 'wgMaxArticleSize', 1 );
 -              // Supply services with updated globals
 -              $this->overrideMwServices();
  
                $text = str_repeat( '!', 1025 );
  
                        'The action you have requested is limited to users in the group: ' );
  
                $this->setMwGlobals( 'wgRevokePermissions', [ '*' => [ 'edit' => true ] ] );
 -              // Supply services with updated globals
 -              $this->overrideMwServices();
  
                $this->doApiRequestWithToken( [
                        'action' => 'edit',
  
                $this->setMwGlobals( 'wgRevokePermissions',
                        [ 'user' => [ 'editcontentmodel' => true ] ] );
 -              // Supply services with updated globals
 -              $this->overrideMwServices();
  
                $this->doApiRequestWithToken( [
                        'action' => 'edit',