rdbms: reorganize Database fields and constants
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 13 Jun 2019 11:27:30 +0000 (12:27 +0100)
committerKrinkle <krinklemail@gmail.com>
Thu, 13 Jun 2019 17:39:24 +0000 (17:39 +0000)
commitf5880b7dc741aa0c1b9f4b420feccef349369cc0
tree9b68135c11d857c566b0407f0976f3f4769a6db1
parent84395e9f3dab6779740c922963b6d9d961015550
rdbms: reorganize Database fields and constants

Move the constants to the bottom and make more of them private.
Place the configuration fields at the top of the list.
Also, move some related fields closer to each other.

In addition:
* Rename the named lock tracking variable to start with the
  prefix "session" for consistency.
* Remove unused $preparedArgs field.
* Rename $sessionVars and $rttEstimate fields.
* Use short field documentation syntax.
* Make transaction callback fields private.

Change-Id: I7d78be6744723f4d7bb32a75154564ee04eca0f6
includes/libs/rdbms/database/Database.php
includes/libs/rdbms/database/DatabaseMysqlBase.php
includes/libs/rdbms/database/DatabaseSqlite.php
includes/libs/rdbms/database/IDatabase.php