dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ff355e8) | patch
Revert "User::saveOptions() optimization"
authorMattflaschen <mflaschen@wikimedia.org>
Thu, 30 Jan 2014 23:38:59 +0000 (23:38 +0000)
committerLegoktm <legoktm.wikipedia@gmail.com>
Fri, 31 Jan 2014 00:37:24 +0000 (00:37 +0000)
commit2855210048d6056601b4afa6dc0a53cf861eb011
treea295950b9cd5a6bd52f631a6804a0d37f1353bectree | snapshot
parentff355e87e2f7a41a87c37f43232a44113cb033e0commit | diff
Revert "User::saveOptions() optimization"

The hooks are not actually being called multiple times,
since getDefaultOptions caches its return value
(except while unit testing).

However, this change caused a regression due to different
handling of saved values (e.g. false no longer saves
when the default is true).

This reverts commit ff355e87e2f7a41a87c37f43232a44113cb033e0.

Bug: 60653
Change-Id: Ibbd34dde5ec5fafbdf6097337cc0fa94614f0b85
includes/User.php diff | blob | history
tests/phpunit/includes/UserTest.php diff | blob | history
Wiklou, le Wiki du Wiklou