Merge "[search] Fix method call on null value"

[lhc/web/wiklou.git] / includes / media / TransformationalImageHandler.php

diff --git a/includes/media/TransformationalImageHandler.php b/includes/media/TransformationalImageHandler.php
index 3558149..30f9e2e 100644 (file)
--- a/includes/media/TransformationalImageHandler.php
+++ b/includes/media/TransformationalImageHandler.php
@@ -508,9 +508,10 @@ abstract class TransformationalImageHandler extends ImageHandler {
         * @return string|bool Representing the IM version; false on error
         */
        protected function getMagickVersion() {
-               return ObjectCache::newAccelerator( CACHE_NONE )->getWithSetCallback(
-                       "imagemagick-version",
-                       3600,
+               $cache = ObjectCache::newAccelerator( CACHE_NONE );
+               return $cache->getWithSetCallback(
+                       'imagemagick-version',
+                       $cache::TTL_HOUR,
                        function () {
                                global $wgImageMagickConvertCommand;
 
@@ -523,7 +524,6 @@ abstract class TransformationalImageHandler extends ImageHandler {
                                );
                                if ( $x != 1 ) {
                                        wfDebug( __METHOD__ . ": ImageMagick version check failed\n" );
-
                                        return false;
                                }