includes/exception/MWExceptionHandler.php

   1 <?php
   2 /**
   3  * This program is free software; you can redistribute it and/or modify
   4  * it under the terms of the GNU General Public License as published by
   5  * the Free Software Foundation; either version 2 of the License, or
   6  * (at your option) any later version.
   7  *
   8  * This program is distributed in the hope that it will be useful,
   9  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  10  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  11  * GNU General Public License for more details.
  12  *
  13  * You should have received a copy of the GNU General Public License along
  14  * with this program; if not, write to the Free Software Foundation, Inc.,
  15  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  16  * http://www.gnu.org/copyleft/gpl.html
  17  *
  18  * @file
  19  */
  20
  21 use MediaWiki\Logger\LoggerFactory;
  22
  23 /**
  24  * Handler class for MWExceptions
  25  * @ingroup Exception
  26  */
  27 class MWExceptionHandler {
  28
  29         /**
  30          * @var string $reservedMemory
  31          */
  32         protected static $reservedMemory;
  33         /**
  34          * @var array $fatalErrorTypes
  35          */
  36         protected static $fatalErrorTypes = array(
  37                 E_ERROR, E_PARSE, E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR,
  38                 /* HHVM's FATAL_ERROR level */ 16777217,
  39         );
  40         /**
  41          * @var bool $handledFatalCallback
  42          */
  43         protected static $handledFatalCallback = false;
  44
  45         /**
  46          * Install handlers with PHP.
  47          */
  48         public static function installHandler() {
  49                 set_exception_handler( 'MWExceptionHandler::handleException' );
  50                 set_error_handler( 'MWExceptionHandler::handleError' );
  51
  52                 // Reserve 16k of memory so we can report OOM fatals
  53                 self::$reservedMemory = str_repeat( ' ', 16384 );
  54                 register_shutdown_function( 'MWExceptionHandler::handleFatalError' );
  55         }
  56
  57         /**
  58          * Report an exception to the user
  59          * @param Exception|Throwable $e
  60          */
  61         protected static function report( $e ) {
  62                 global $wgShowExceptionDetails;
  63
  64                 $cmdLine = MWException::isCommandLine();
  65
  66                 if ( $e instanceof MWException ) {
  67                         try {
  68                                 // Try and show the exception prettily, with the normal skin infrastructure
  69                                 $e->report();
  70                         } catch ( Exception $e2 ) {
  71                                 // Exception occurred from within exception handler
  72                                 // Show a simpler message for the original exception,
  73                                 // don't try to invoke report()
  74                                 $message = "MediaWiki internal error.\n\n";
  75
  76                                 if ( $wgShowExceptionDetails ) {
  77                                         $message .= 'Original exception: ' . self::getLogMessage( $e ) .
  78                                                 "\nBacktrace:\n" . self::getRedactedTraceAsString( $e ) .
  79                                                 "\n\nException caught inside exception handler: " . self::getLogMessage( $e2 ) .
  80                                                 "\nBacktrace:\n" . self::getRedactedTraceAsString( $e2 );
  81                                 } else {
  82                                         $message .= "Exception caught inside exception handler.\n\n" .
  83                                                 "Set \$wgShowExceptionDetails = true; at the bottom of LocalSettings.php " .
  84                                                 "to show detailed debugging information.";
  85                                 }
  86
  87                                 $message .= "\n";
  88
  89                                 if ( $cmdLine ) {
  90                                         self::printError( $message );
  91                                 } else {
  92                                         echo nl2br( htmlspecialchars( $message ) ) . "\n";
  93                                 }
  94                         }
  95                 } else {
  96                         $message = "Exception encountered, of type \"" . get_class( $e ) . "\"";
  97
  98                         if ( $wgShowExceptionDetails ) {
  99                                 $message .= "\n" . self::getLogMessage( $e ) . "\nBacktrace:\n" .
 100                                         self::getRedactedTraceAsString( $e ) . "\n";
 101                         }
 102
 103                         if ( $cmdLine ) {
 104                                 self::printError( $message );
 105                         } else {
 106                                 echo nl2br( htmlspecialchars( $message ) ) . "\n";
 107                         }
 108
 109                 }
 110         }
 111
 112         /**
 113          * Print a message, if possible to STDERR.
 114          * Use this in command line mode only (see isCommandLine)
 115          *
 116          * @param string $message Failure text
 117          */
 118         public static function printError( $message ) {
 119                 # NOTE: STDERR may not be available, especially if php-cgi is used from the
 120                 # command line (bug #15602). Try to produce meaningful output anyway. Using
 121                 # echo may corrupt output to STDOUT though.
 122                 if ( defined( 'STDERR' ) ) {
 123                         fwrite( STDERR, $message );
 124                 } else {
 125                         echo $message;
 126                 }
 127         }
 128
 129         /**
 130          * If there are any open database transactions, roll them back and log
 131          * the stack trace of the exception that should have been caught so the
 132          * transaction could be aborted properly.
 133          *
 134          * @since 1.23
 135          * @param Exception|Throwable $e
 136          */
 137         public static function rollbackMasterChangesAndLog( $e ) {
 138                 $factory = wfGetLBFactory();
 139                 if ( $factory->hasMasterChanges() ) {
 140                         $logger = LoggerFactory::getInstance( 'Bug56269' );
 141                         $logger->warning(
 142                                 'Exception thrown with an uncommited database transaction: ' .
 143                                 self::getLogMessage( $e ),
 144                                 self::getLogContext( $e )
 145                         );
 146                         $factory->rollbackMasterChanges();
 147                 }
 148         }
 149
 150         /**
 151          * Exception handler which simulates the appropriate catch() handling:
 152          *
 153          *   try {
 154          *       ...
 155          *   } catch ( Exception $e ) {
 156          *       $e->report();
 157          *   } catch ( Exception $e ) {
 158          *       echo $e->__toString();
 159          *   }
 160          *
 161          * @since 1.25
 162          * @param Exception|Throwable $e
 163          */
 164         public static function handleException( $e ) {
 165                 try {
 166                         // Rollback DBs to avoid transaction notices. This may fail
 167                         // to rollback some DB due to connection issues or exceptions.
 168                         // However, any sane DB driver will rollback implicitly anyway.
 169                         self::rollbackMasterChangesAndLog( $e );
 170                 } catch ( DBError $e2 ) {
 171                         // If the DB is unreacheable, rollback() will throw an error
 172                         // and the error report() method might need messages from the DB,
 173                         // which would result in an exception loop. PHP may escalate such
 174                         // errors to "Exception thrown without a stack frame" fatals, but
 175                         // it's better to be explicit here.
 176                         self::logException( $e2 );
 177                 }
 178
 179                 self::logException( $e );
 180                 self::report( $e );
 181
 182                 // Exit value should be nonzero for the benefit of shell jobs
 183                 exit( 1 );
 184         }
 185
 186         /**
 187          * Handler for set_error_handler() callback notifications.
 188          *
 189          * Receive a callback from the interpreter for a raised error, create an
 190          * ErrorException, and log the exception to the 'error' logging
 191          * channel(s). If the raised error is a fatal error type (only under HHVM)
 192          * delegate to handleFatalError() instead.
 193          *
 194          * @since 1.25
 195          *
 196          * @param int $level Error level raised
 197          * @param string $message
 198          * @param string $file
 199          * @param int $line
 200          * @return bool
 201          *
 202          * @see logError()
 203          */
 204         public static function handleError(
 205                 $level, $message, $file = null, $line = null
 206         ) {
 207                 if ( in_array( $level, self::$fatalErrorTypes ) ) {
 208                         return call_user_func_array(
 209                                 'MWExceptionHandler::handleFatalError', func_get_args()
 210                         );
 211                 }
 212
 213                 // Map error constant to error name (reverse-engineer PHP error
 214                 // reporting)
 215                 switch ( $level ) {
 216                         case E_RECOVERABLE_ERROR:
 217                                 $levelName = 'Error';
 218                                 break;
 219                         case E_WARNING:
 220                         case E_CORE_WARNING:
 221                         case E_COMPILE_WARNING:
 222                         case E_USER_WARNING:
 223                                 $levelName = 'Warning';
 224                                 break;
 225                         case E_NOTICE:
 226                         case E_USER_NOTICE:
 227                                 $levelName = 'Notice';
 228                                 break;
 229                         case E_STRICT:
 230                                 $levelName = 'Strict Standards';
 231                                 break;
 232                         case E_DEPRECATED:
 233                         case E_USER_DEPRECATED:
 234                                 $levelName = 'Deprecated';
 235                                 break;
 236                         default:
 237                                 $levelName = 'Unknown error';
 238                                 break;
 239                 }
 240
 241                 $e = new ErrorException( "PHP $levelName: $message", 0, $level, $file, $line );
 242                 self::logError( $e, 'error' );
 243
 244                 // This handler is for logging only. Return false will instruct PHP
 245                 // to continue regular handling.
 246                 return false;
 247         }
 248
 249
 250         /**
 251          * Dual purpose callback used as both a set_error_handler() callback and
 252          * a registered shutdown function. Receive a callback from the interpreter
 253          * for a raised error or system shutdown, check for a fatal error, and log
 254          * to the 'fatal' logging channel.
 255          *
 256          * Special handling is included for missing class errors as they may
 257          * indicate that the user needs to install 3rd-party libraries via
 258          * Composer or other means.
 259          *
 260          * @since 1.25
 261          *
 262          * @param int $level Error level raised
 263          * @param string $message Error message
 264          * @param string $file File that error was raised in
 265          * @param int $line Line number error was raised at
 266          * @param array $context Active symbol table point of error
 267          * @param array $trace Backtrace at point of error (undocumented HHVM
 268          *     feature)
 269          * @return bool Always returns false
 270          */
 271         public static function handleFatalError(
 272                 $level = null, $message = null, $file = null, $line = null,
 273                 $context = null, $trace = null
 274         ) {
 275                 // Free reserved memory so that we have space to process OOM
 276                 // errors
 277                 self::$reservedMemory = null;
 278
 279                 if ( $level === null ) {
 280                         // Called as a shutdown handler, get data from error_get_last()
 281                         if ( static::$handledFatalCallback ) {
 282                                 // Already called once (probably as an error handler callback
 283                                 // under HHVM) so don't log again.
 284                                 return false;
 285                         }
 286
 287                         $lastError = error_get_last();
 288                         if ( $lastError !== null ) {
 289                                 $level = $lastError['type'];
 290                                 $message = $lastError['message'];
 291                                 $file = $lastError['file'];
 292                                 $line = $lastError['line'];
 293                         } else {
 294                                 $level = 0;
 295                                 $message = '';
 296                         }
 297                 }
 298
 299                 if ( !in_array( $level, self::$fatalErrorTypes ) ) {
 300                         // Only interested in fatal errors, others should have been
 301                         // handled by MWExceptionHandler::handleError
 302                         return false;
 303                 }
 304
 305                 $msg = "[{exception_id}] PHP Fatal Error: {$message}";
 306
 307                 // Look at message to see if this is a class not found failure
 308                 // HHVM: Class undefined: foo
 309                 // PHP5: Class 'foo' not found
 310                 if ( preg_match( "/Class (undefined: \w+|'\w+' not found)/", $msg ) ) {
 311                         // @codingStandardsIgnoreStart Generic.Files.LineLength.TooLong
 312                         $msg = <<<TXT
 313 {$msg}
 314
 315 MediaWiki or an installed extension requires this class but it is not embedded directly in MediaWiki's git repository and must be installed separately by the end user.
 316
 317 Please see <a href="https://www.mediawiki.org/wiki/Download_from_Git#Fetch_external_libraries">mediawiki.org</a> for help on installing the required components.
 318 TXT;
 319                         // @codingStandardsIgnoreEnd
 320                 }
 321
 322                 // We can't just create an exception and log it as it is likely that
 323                 // the interpreter has unwound the stack already. If that is true the
 324                 // stacktrace we would get would be functionally empty. If however we
 325                 // have been called as an error handler callback *and* HHVM is in use
 326                 // we will have been provided with a useful stacktrace that we can
 327                 // log.
 328                 $trace = $trace ?: debug_backtrace();
 329                 $logger = LoggerFactory::getInstance( 'fatal' );
 330                 $logger->error( $msg, array(
 331                         'exception' => array(
 332                                 'class' => 'ErrorException',
 333                                 'message' => "PHP Fatal Error: {$message}",
 334                                 'code' => $level,
 335                                 'file' => $file,
 336                                 'line' => $line,
 337                                 'trace' => static::redactTrace( $trace ),
 338                         ),
 339                         'exception_id' => wfRandomString( 8 ),
 340                 ) );
 341
 342                 // Remember call so we don't double process via HHVM's fatal
 343                 // notifications and the shutdown hook behavior
 344                 static::$handledFatalCallback = true;
 345                 return false;
 346         }
 347
 348         /**
 349          * Generate a string representation of an exception's stack trace
 350          *
 351          * Like Exception::getTraceAsString, but replaces argument values with
 352          * argument type or class name.
 353          *
 354          * @param Exception|Throwable $e
 355          * @return string
 356          * @see prettyPrintTrace()
 357          */
 358         public static function getRedactedTraceAsString( $e ) {
 359                 return self::prettyPrintTrace( self::getRedactedTrace( $e ) );
 360         }
 361
 362         /**
 363          * Generate a string representation of a stacktrace.
 364          *
 365          * @param array $trace
 366          * @param string $pad Constant padding to add to each line of trace
 367          * @return string
 368          * @since 1.26
 369          */
 370         public static function prettyPrintTrace( array $trace, $pad = '' ) {
 371                 $text = '';
 372
 373                 $level = 0;
 374                 foreach ( $trace as $level => $frame ) {
 375                         if ( isset( $frame['file'] ) && isset( $frame['line'] ) ) {
 376                                 $text .= "{$pad}#{$level} {$frame['file']}({$frame['line']}): ";
 377                         } else {
 378                                 // 'file' and 'line' are unset for calls via call_user_func
 379                                 // (bug 55634) This matches behaviour of
 380                                 // Exception::getTraceAsString to instead display "[internal
 381                                 // function]".
 382                                 $text .= "{$pad}#{$level} [internal function]: ";
 383                         }
 384
 385                         if ( isset( $frame['class'] ) && isset( $frame['type'] ) && isset( $frame['function'] ) ) {
 386                                 $text .= $frame['class'] . $frame['type'] . $frame['function'];
 387                         } elseif ( isset( $frame['function'] ) ) {
 388                                 $text .= $frame['function'];
 389                         } else {
 390                                 $text .= 'NO_FUNCTION_GIVEN';
 391                         }
 392
 393                         if ( isset( $frame['args'] ) ) {
 394                                 $text .= '(' . implode( ', ', $frame['args'] ) . ")\n";
 395                         } else {
 396                                 $text .= "()\n";
 397                         }
 398                 }
 399
 400                 $level = $level + 1;
 401                 $text .= "{$pad}#{$level} {main}";
 402
 403                 return $text;
 404         }
 405
 406         /**
 407          * Return a copy of an exception's backtrace as an array.
 408          *
 409          * Like Exception::getTrace, but replaces each element in each frame's
 410          * argument array with the name of its class (if the element is an object)
 411          * or its type (if the element is a PHP primitive).
 412          *
 413          * @since 1.22
 414          * @param Exception|Throwable $e
 415          * @return array
 416          */
 417         public static function getRedactedTrace( $e ) {
 418                 return static::redactTrace( $e->getTrace() );
 419         }
 420
 421         /**
 422          * Redact a stacktrace generated by Exception::getTrace(),
 423          * debug_backtrace() or similar means. Replaces each element in each
 424          * frame's argument array with the name of its class (if the element is an
 425          * object) or its type (if the element is a PHP primitive).
 426          *
 427          * @since 1.26
 428          * @param array $trace Stacktrace
 429          * @return array Stacktrace with arugment values converted to data types
 430          */
 431         public static function redactTrace( array $trace ) {
 432                 return array_map( function ( $frame ) {
 433                         if ( isset( $frame['args'] ) ) {
 434                                 $frame['args'] = array_map( function ( $arg ) {
 435                                         return is_object( $arg ) ? get_class( $arg ) : gettype( $arg );
 436                                 }, $frame['args'] );
 437                         }
 438                         return $frame;
 439                 }, $trace );
 440         }
 441
 442         /**
 443          * Get the ID for this exception.
 444          *
 445          * The ID is saved so that one can match the one output to the user (when
 446          * $wgShowExceptionDetails is set to false), to the entry in the debug log.
 447          *
 448          * @since 1.22
 449          * @param Exception|Throwable $e
 450          * @return string
 451          */
 452         public static function getLogId( $e ) {
 453                 if ( !isset( $e->_mwLogId ) ) {
 454                         $e->_mwLogId = wfRandomString( 8 );
 455                 }
 456                 return $e->_mwLogId;
 457         }
 458
 459         /**
 460          * If the exception occurred in the course of responding to a request,
 461          * returns the requested URL. Otherwise, returns false.
 462          *
 463          * @since 1.23
 464          * @return string|false
 465          */
 466         public static function getURL() {
 467                 global $wgRequest;
 468                 if ( !isset( $wgRequest ) || $wgRequest instanceof FauxRequest ) {
 469                         return false;
 470                 }
 471                 return $wgRequest->getRequestURL();
 472         }
 473
 474         /**
 475          * Get a message formatting the exception message and its origin.
 476          *
 477          * @since 1.22
 478          * @param Exception|Throwable $e
 479          * @return string
 480          */
 481         public static function getLogMessage( $e ) {
 482                 $id = self::getLogId( $e );
 483                 $type = get_class( $e );
 484                 $file = $e->getFile();
 485                 $line = $e->getLine();
 486                 $message = $e->getMessage();
 487                 $url = self::getURL() ?: '[no req]';
 488
 489                 return "[$id] $url   $type from line $line of $file: $message";
 490         }
 491
 492         public static function getPublicLogMessage( Exception $e ) {
 493                 $logId = self::getLogId( $e );
 494                 $type = get_class( $e );
 495                 return '[' . $logId . '] '
 496                         . gmdate( 'Y-m-d H:i:s' ) . ': '
 497                         . 'Fatal exception of type ' . $type;
 498         }
 499
 500         /**
 501          * Get a PSR-3 log event context from an Exception.
 502          *
 503          * Creates a structured array containing information about the provided
 504          * exception that can be used to augment a log message sent to a PSR-3
 505          * logger.
 506          *
 507          * @param Exception|Throwable $e
 508          * @return array
 509          */
 510         public static function getLogContext( $e ) {
 511                 return array(
 512                         'exception' => $e,
 513                         'exception_id' => static::getLogId( $e ),
 514                 );
 515         }
 516
 517         /**
 518          * Get a structured representation of an Exception.
 519          *
 520          * Returns an array of structured data (class, message, code, file,
 521          * backtrace) derived from the given exception. The backtrace information
 522          * will be redacted as per getRedactedTraceAsArray().
 523          *
 524          * @param Exception|Throwable $e
 525          * @return array
 526          * @since 1.26
 527          */
 528         public static function getStructuredExceptionData( $e ) {
 529                 global $wgLogExceptionBacktrace;
 530                 $data = array(
 531                         'id' => self::getLogId( $e ),
 532                         'type' => get_class( $e ),
 533                         'file' => $e->getFile(),
 534                         'line' => $e->getLine(),
 535                         'message' => $e->getMessage(),
 536                         'code' => $e->getCode(),
 537                         'url' => self::getURL() ?: null,
 538                 );
 539
 540                 if ( $e instanceof ErrorException &&
 541                         ( error_reporting() & $e->getSeverity() ) === 0
 542                 ) {
 543                         // Flag surpressed errors
 544                         $data['suppressed'] = true;
 545                 }
 546
 547                 if ( $wgLogExceptionBacktrace ) {
 548                         $data['backtrace'] = self::getRedactedTrace( $e );
 549                 }
 550
 551                 $previous = $e->getPrevious();
 552                 if ( $previous !== null ) {
 553                         $data['previous'] = self::getStructuredExceptionData( $previous );
 554                 }
 555
 556                 return $data;
 557         }
 558
 559         /**
 560          * Serialize an Exception object to JSON.
 561          *
 562          * The JSON object will have keys 'id', 'file', 'line', 'message', and
 563          * 'url'. These keys map to string values, with the exception of 'line',
 564          * which is a number, and 'url', which may be either a string URL or or
 565          * null if the exception did not occur in the context of serving a web
 566          * request.
 567          *
 568          * If $wgLogExceptionBacktrace is true, it will also have a 'backtrace'
 569          * key, mapped to the array return value of Exception::getTrace, but with
 570          * each element in each frame's "args" array (if set) replaced with the
 571          * argument's class name (if the argument is an object) or type name (if
 572          * the argument is a PHP primitive).
 573          *
 574          * @par Sample JSON record ($wgLogExceptionBacktrace = false):
 575          * @code
 576          *  {
 577          *    "id": "c41fb419",
 578          *    "type": "MWException",
 579          *    "file": "/var/www/mediawiki/includes/cache/MessageCache.php",
 580          *    "line": 704,
 581          *    "message": "Non-string key given",
 582          *    "url": "/wiki/Main_Page"
 583          *  }
 584          * @endcode
 585          *
 586          * @par Sample JSON record ($wgLogExceptionBacktrace = true):
 587          * @code
 588          *  {
 589          *    "id": "dc457938",
 590          *    "type": "MWException",
 591          *    "file": "/vagrant/mediawiki/includes/cache/MessageCache.php",
 592          *    "line": 704,
 593          *    "message": "Non-string key given",
 594          *    "url": "/wiki/Main_Page",
 595          *    "backtrace": [{
 596          *      "file": "/vagrant/mediawiki/extensions/VisualEditor/VisualEditor.hooks.php",
 597          *      "line": 80,
 598          *      "function": "get",
 599          *      "class": "MessageCache",
 600          *      "type": "->",
 601          *      "args": ["array"]
 602          *    }]
 603          *  }
 604          * @endcode
 605          *
 606          * @since 1.23
 607          * @param Exception|Throwable $e
 608          * @param bool $pretty Add non-significant whitespace to improve readability (default: false).
 609          * @param int $escaping Bitfield consisting of FormatJson::.*_OK class constants.
 610          * @return string|false JSON string if successful; false upon failure
 611          */
 612         public static function jsonSerializeException( $e, $pretty = false, $escaping = 0 ) {
 613                 $data = self::getStructuredExceptionData( $e );
 614                 return FormatJson::encode( $data, $pretty, $escaping );
 615         }
 616
 617         /**
 618          * Log an exception to the exception log (if enabled).
 619          *
 620          * This method must not assume the exception is an MWException,
 621          * it is also used to handle PHP exceptions or exceptions from other libraries.
 622          *
 623          * @since 1.22
 624          * @param Exception|Throwable $e
 625          */
 626         public static function logException( $e ) {
 627                 if ( !( $e instanceof MWException ) || $e->isLoggable() ) {
 628                         $logger = LoggerFactory::getInstance( 'exception' );
 629                         $logger->error(
 630                                 self::getLogMessage( $e ),
 631                                 self::getLogContext( $e )
 632                         );
 633
 634                         $json = self::jsonSerializeException( $e, false, FormatJson::ALL_OK );
 635                         if ( $json !== false ) {
 636                                 $logger = LoggerFactory::getInstance( 'exception-json' );
 637                                 $logger->error( $json, array( 'private' => true ) );
 638                         }
 639
 640                         Hooks::run( 'LogException', array( $e, false ) );
 641                 }
 642         }
 643
 644         /**
 645          * Log an exception that wasn't thrown but made to wrap an error.
 646          *
 647          * @since 1.25
 648          * @param ErrorException $e
 649          * @param string $channel
 650         */
 651         protected static function logError( ErrorException $e, $channel ) {
 652                 // The set_error_handler callback is independent from error_reporting.
 653                 // Filter out unwanted errors manually (e.g. when
 654                 // MediaWiki\suppressWarnings is active).
 655                 $suppressed = ( error_reporting() & $e->getSeverity() ) === 0;
 656                 if ( !$suppressed ) {
 657                         $logger = LoggerFactory::getInstance( $channel );
 658                         $logger->error(
 659                                 self::getLogMessage( $e ),
 660                                 self::getLogContext( $e )
 661                         );
 662                 }
 663
 664                 // Include all errors in the json log (surpressed errors will be flagged)
 665                 $json = self::jsonSerializeException( $e, false, FormatJson::ALL_OK );
 666                 if ( $json !== false ) {
 667                         $logger = LoggerFactory::getInstance( "{$channel}-json" );
 668                         $logger->error( $json, array( 'private' => true ) );
 669                 }
 670
 671                 Hooks::run( 'LogException', array( $e, $suppressed ) );
 672         }
 673 }