From: Lucas Werkmeister <lucas.werkmeister@wikimedia.de>
Date: Wed, 11 Sep 2019 16:54:19 +0000 (+0200)
Subject: FauxRequest: don’t override getValues()
X-Git-Tag: 1.34.0-rc.0~122^2
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dcompta/comptes/%7B%7B%20url_for%28%27user_settings%27%2C%20userid=session.user.id%29%20%7D%7D?a=commitdiff_plain;h=568631af97fdde99d1b218776c94b298c0fb171e;p=lhc%2Fweb%2Fwiklou.git

FauxRequest: don’t override getValues()

As far as I can tell, the override is not necessary (the only other
method that the original implementation uses is getGPCVal(), which
FauxRequest still uses elsewhere), and it breaks tests that rely on the
filtering behavior.

Change-Id: I7dd0a8dd36e31cc6784364d56e460b55bff6ea59
---

diff --git a/includes/FauxRequest.php b/includes/FauxRequest.php
index 78f6ca9afa..9337270303 100644
--- a/includes/FauxRequest.php
+++ b/includes/FauxRequest.php
@@ -86,14 +86,6 @@ class FauxRequest extends WebRequest {
 		return (string)$this->getVal( $name, $default );
 	}
 
-	/**
-	 * @return array
-	 * @suppress PhanParamSignatureMismatch
-	 */
-	public function getValues() {
-		return $this->data;
-	}
-
 	/**
 	 * @return array
 	 */