From de9793550016f8b93cd7d3e0e48f29dc604d1f25 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Mon, 16 Apr 2018 20:05:12 +0200 Subject: [PATCH] mw.widgets.visibleLengthLimit: Apply number conversion to the limit In languages like Persian (fa) or Hindi (hi) this should probably use localised numerals. Change-Id: Iba40634038079deba1c26bacb515f4791b4d38db --- resources/Resources.php | 1 + .../mediawiki.widgets.visibleLengthLimit.js | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/resources/Resources.php b/resources/Resources.php index 0595bb031c..2f230f23e0 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -2536,6 +2536,7 @@ return [ 'dependencies' => [ 'oojs-ui-core', 'jquery.lengthLimit', + 'mediawiki.language', 'mediawiki.String', ], 'targets' => [ 'desktop', 'mobile' ] diff --git a/resources/src/mediawiki.widgets.visibleLengthLimit/mediawiki.widgets.visibleLengthLimit.js b/resources/src/mediawiki.widgets.visibleLengthLimit/mediawiki.widgets.visibleLengthLimit.js index 52ebe7478e..c92c5e5beb 100644 --- a/resources/src/mediawiki.widgets.visibleLengthLimit/mediawiki.widgets.visibleLengthLimit.js +++ b/resources/src/mediawiki.widgets.visibleLengthLimit/mediawiki.widgets.visibleLengthLimit.js @@ -19,7 +19,9 @@ limit = limit || +textInputWidget.$input.attr( 'maxlength' ); function updateCount() { - textInputWidget.setLabel( ( limit - byteLength( textInputWidget.getValue() ) ).toString() ); + var remaining = limit - byteLength( textInputWidget.getValue() ); + remaining = mw.language.convertNumber( remaining ); + textInputWidget.setLabel( remaining ); } textInputWidget.on( 'change', updateCount ); // Initialise value @@ -41,7 +43,9 @@ limit = limit || +textInputWidget.$input.attr( 'maxlength' ); function updateCount() { - textInputWidget.setLabel( ( limit - codePointLength( textInputWidget.getValue() ) ).toString() ); + var remaining = limit - codePointLength( textInputWidget.getValue() ); + remaining = mw.language.convertNumber( remaining ); + textInputWidget.setLabel( remaining ); } textInputWidget.on( 'change', updateCount ); // Initialise value -- 2.20.1