From bafa1bfdb128deeca558e45361003eb6b262cbaa Mon Sep 17 00:00:00 2001
From: Chad Horohoe <demon@users.mediawiki.org>
Date: Tue, 10 May 2011 22:54:59 +0000
Subject: [PATCH] Turn forUpdate() into an actual no-op

---
 includes/Article.php | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/includes/Article.php b/includes/Article.php
index 68290a6291..b3cd3b42d0 100644
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -27,7 +27,6 @@ class Article {
 	var $mContentLoaded = false;      // !<
 	var $mCounter = -1;               // !< Not loaded
 	var $mDataLoaded = false;         // !<
-	var $mForUpdate = false;          // !<
 	var $mGoodAdjustment = 0;         // !<
 	var $mIsRedirect = false;         // !<
 	var $mLatest = false;             // !<
@@ -263,7 +262,6 @@ class Article {
 		$this->mTimestamp = '';
 		$this->mGoodAdjustment = $this->mTotalAdjustment = 0;
 		$this->mTouched = '19700101000000';
-		$this->mForUpdate = false;
 		$this->mIsRedirect = false;
 		$this->mRevIdFetched = 0;
 		$this->mRedirectUrl = false;
@@ -587,15 +585,11 @@ class Article {
 	}
 
 	/**
-	 * Read/write accessor to select FOR UPDATE
+	 * No-op
 	 * @deprecated since 1.18
-	 *
-	 * @param $x Mixed: FIXME
-	 * @return mixed value of $x, or value stored in Article::mForUpdate
 	 */
-	public function forUpdate( $x = null ) {
+	public function forUpdate() {
 		wfDeprecated( __METHOD__ );
-		return wfSetVar( $this->mForUpdate, $x );
 	}
 
 	/**
-- 
2.20.1