From 7e4d49b9bcd5cb585272eca0b3ba18d71787db42 Mon Sep 17 00:00:00 2001 From: Krinkle Date: Fri, 13 May 2011 15:28:44 +0000 Subject: [PATCH] Looks like even margin-top isn't save due to box model differences (ie. becomes 6px in WebKit browser...?). Using visibility insteawd. (Follow-up to r87938, r87970) --- resources/test/unit/mediawiki.util/mediawiki.util.js | 4 ++-- resources/test/unit/mediawiki/mediawiki.js | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/resources/test/unit/mediawiki.util/mediawiki.util.js b/resources/test/unit/mediawiki.util/mediawiki.util.js index 45979c3e58..c6ea77fd1c 100644 --- a/resources/test/unit/mediawiki.util/mediawiki.util.js +++ b/resources/test/unit/mediawiki.util/mediawiki.util.js @@ -20,12 +20,12 @@ test( 'wikiUrlencode', function(){ test( 'addCSS', function(){ - var a = mw.util.addCSS( '#bodyContent { margin-top: 5px; }' ); + var a = mw.util.addCSS( '#bodyContent { visibility: hidden; }' ); ok( a, 'function works' ); same( a.disabled, false, 'property "disabled" is available and set to false' ); var $b = $('#bodyContent'); - equals( $b.css('margin-top'), '5px', 'Added style properties are in effect.' ); + equals( $b.css('visibility'), 'hidden', 'Added style properties are in effect.' ); }); diff --git a/resources/test/unit/mediawiki/mediawiki.js b/resources/test/unit/mediawiki/mediawiki.js index 2e75b7271f..b6028939b9 100644 --- a/resources/test/unit/mediawiki/mediawiki.js +++ b/resources/test/unit/mediawiki/mediawiki.js @@ -129,9 +129,6 @@ test( 'mw.user', function(){ test( 'mw.loader', function(){ - // @TODO: More elaborate testing ? - // Difficult due to modules already being loaded - // through it at this point ok( mw.loader, 'loader defined' ); ok( mw.loader.work, 'loader.work defined' ); ok( mw.loader.register, 'loader.register defined' ); -- 2.20.1