From 48fc04e656d15c6c5ab19b0ffa8b386ee796381e Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Tue, 26 Apr 2016 15:09:28 -0700 Subject: [PATCH] Optimize consistencyCheck() in FileBackendMultiwrite doOperationsInternal() already set "preserveCache" but never actually filled it in to begin with. This should lower round trips if sync checks are enabled. Change-Id: Ica67b8d66e7602faed842408365edbd466688f61 --- includes/filebackend/FileBackendMultiWrite.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/includes/filebackend/FileBackendMultiWrite.php b/includes/filebackend/FileBackendMultiWrite.php index 0d7bf6696a..c432025c2c 100644 --- a/includes/filebackend/FileBackendMultiWrite.php +++ b/includes/filebackend/FileBackendMultiWrite.php @@ -241,6 +241,12 @@ class FileBackendMultiWrite extends FileBackend { return $status; // skip checks } + // Preload all of the stat info in as few round trips as possible... + foreach ( $this->backends as $backend ) { + $realPaths = $this->substPaths( $paths, $backend ); + $backend->preloadFileStat( [ 'srcs' => $realPaths, 'latest' => true ] ); + } + $mBackend = $this->backends[$this->masterIndex]; foreach ( $paths as $path ) { $params = [ 'src' => $path, 'latest' => true ]; -- 2.20.1