From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Wed, 14 Dec 2016 13:33:13 +0000 (+0100)
Subject: mediawiki.special.apisandbox: Avoid bitwise tricks when checking for integers
X-Git-Tag: 1.31.0-rc.0~4593^2
X-Git-Url: http://git.cyclocoop.org/%40spipnet%40?a=commitdiff_plain;h=d6e6f2f885152f5cde9cac29fddc0d847f229d8b;p=lhc%2Fweb%2Fwiklou.git

mediawiki.special.apisandbox: Avoid bitwise tricks when checking for integers

In addition to being more obvious than `n | 0`, `Math.floor( n )` also
works correctly for numbers outside of 32-bit int range.

Change-Id: I254457500e141c0dd4e28c707fb4a00c1b04c272
---

diff --git a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
index 60155fd50a..43321fe236 100644
--- a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
+++ b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
@@ -408,8 +408,7 @@
 						} else {
 							n = +value;
 							return !isNaN( n ) && isFinite( n ) &&
-								// eslint-disable-next-line no-bitwise
-								( n | 0 ) === n &&
+								Math.floor( n ) === n &&
 								n >= pi.min && n <= pi.apiSandboxMax;
 						}
 					} );