From: Aaron Schulz <aschulz@wikimedia.org>
Date: Mon, 28 Sep 2015 19:18:46 +0000 (-0700)
Subject: resourceloader: Cleaned up makeModuleResponse() param docs
X-Git-Tag: 1.31.0-rc.0~9703^2
X-Git-Url: http://git.cyclocoop.org/%40spipnet%40?a=commitdiff_plain;h=a7c4a1c5f5a9b02b06828429a97b71047e7193b3;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Cleaned up makeModuleResponse() param docs

Change-Id: Iabf53452598e13a98241793c317ceffb746aa46e
---

diff --git a/includes/resourceloader/ResourceLoader.php b/includes/resourceloader/ResourceLoader.php
index c20d38642a..02793853f7 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -956,8 +956,8 @@ class ResourceLoader implements LoggerAwareInterface {
 	 * Generate code for a response.
 	 *
 	 * @param ResourceLoaderContext $context Context in which to generate a response
-	 * @param array $modules List of module objects keyed by module name
-	 * @param array $missing List of requested module names that are unregistered (optional)
+	 * @param ResourceLoaderModule[] $modules List of module objects keyed by module name
+	 * @param string[] $missing List of requested module names that are unregistered (optional)
 	 * @return string Response data
 	 */
 	public function makeModuleResponse( ResourceLoaderContext $context,
@@ -1246,7 +1246,7 @@ MESSAGE;
 	}
 
 	private static function isEmptyObject( stdClass $obj ) {
-		foreach ( $obj as $key => &$value ) {
+		foreach ( $obj as $key => $value ) {
 			return false;
 		}
 		return true;