From: Rotem Liss <rotem@users.mediawiki.org>
Date: Thu, 22 Mar 2007 16:14:50 +0000 (+0000)
Subject: Show a notice about unknown messages when rebuilding files.
X-Git-Tag: 1.31.0-rc.0~53641
X-Git-Url: http://git.cyclocoop.org/%40spipnet%40?a=commitdiff_plain;h=8449e0e7659a7fa12522c3d5e16e0bb409954f9c;p=lhc%2Fweb%2Fwiklou.git

Show a notice about unknown messages when rebuilding files.
---

diff --git a/maintenance/language/rebuildLanguage.php b/maintenance/language/rebuildLanguage.php
index 818c395981..d7561e9b7a 100644
--- a/maintenance/language/rebuildLanguage.php
+++ b/maintenance/language/rebuildLanguage.php
@@ -23,7 +23,9 @@ function rebuildLanguage( $code, $write ) {
 	$messages = $messages['all'];
 
 	# Rewrite messages array
-	$messagesText = writeMessagesArray( $messages, $code == 'en' );
+	$messages = writeMessagesArray( $messages, $code == 'en' );
+	$messagesText = $messages[0];
+	$sortedMessages = $messages[1];
 
 	# Write to the file
 	$filename = Language::getMessagesFileName( $code );
@@ -43,6 +45,12 @@ function rebuildLanguage( $code, $write ) {
 				echo "Generated messages for language $code. Please run the script again (without the parameter \"dry-run\") to write the array to the file.\n";
 			}
 		}
+		if ( isset( $sortedMessages['unknown'] ) && !empty( $sortedMessages['unknown'] ) ) {
+			echo "\nThere are " . count( $sortedMessages['unknown'] ) . " unknown messages, please check them:\n";
+			foreach ( $sortedMessages['unknown'] as $key => $value ) {
+				echo "* " . $key . "\n";
+			}
+		}
 	} else {
 		echo "Generated messages for language $code. There seems to be no messages array in the file.\n";
 	}
diff --git a/maintenance/language/writeMessagesArray.inc b/maintenance/language/writeMessagesArray.inc
index e0091bb78a..2f12043476 100644
--- a/maintenance/language/writeMessagesArray.inc
+++ b/maintenance/language/writeMessagesArray.inc
@@ -14,7 +14,7 @@ require_once( 'messageTypes.inc' );
  * @param $messages The messages array.
  * @param $ignoredComments Show comments about ignored and optional messages? (For English.)
  *
- * @return The PHP text.
+ * @return Array of the PHP text and the sorted messages array.
  */
 function writeMessagesArray( $messages, $ignoredComments = false ) {
 	global $wgMessageStructure, $wgBlockComments;
@@ -45,7 +45,7 @@ function writeMessagesArray( $messages, $ignoredComments = false ) {
 	$messagesText .= writeMessagesBlock( 'unknown', 'Unknown messages', $sortedMessages['unknown'], $ignoredComments ); # Write the unknown messages, alphabetically sorted
 	$messagesText .= ");\n";
 
-	return $messagesText;
+	return array( $messagesText, $sortedMessages );
 }
 
 /**